From: Greg KH <gregkh@linuxfoundation.org>
To: angkery <angkery@163.com>
Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Junlin Yang <yangjunlin@yulong.com>
Subject: Re: [PATCH v2] usb: typec: tcpci_maxim: remove redundant assignment
Date: Sun, 24 Jan 2021 14:36:33 +0100 [thread overview]
Message-ID: <YA134dhtrYpt5R/J@kroah.com> (raw)
In-Reply-To: <20210124133137.1468-1-angkery@163.com>
On Sun, Jan 24, 2021 at 09:31:37PM +0800, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> PTR_ERR(chip->tcpci) has been used as a return value,
> it is not necessary to assign it to ret, so remove it.
> And add terminating '\n' to the formats where missed too.
>
> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> ---
> v2: add terminating '\n' to the formats where missed too.
Don't mix different things in the same patch, this should be a patch
series of 2 patches.
thanks,
greg k-h
prev parent reply other threads:[~2021-01-24 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 13:31 [PATCH v2] usb: typec: tcpci_maxim: remove redundant assignment angkery
2021-01-24 13:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA134dhtrYpt5R/J@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=angkery@163.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=yangjunlin@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.