From: Stephan Gerhold <stephan@gerhold.net>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Jonathan Albrieux <jonathan.albrieux@gmail.com>,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer
Date: Sun, 24 Jan 2021 16:51:31 +0100 [thread overview]
Message-ID: <YA2Xg9PboDMc/vu1@gerhold.net> (raw)
In-Reply-To: <e5a65871-08bb-7da9-c298-921395ebf1f8@somainline.org>
On Sun, Jan 24, 2021 at 04:07:19PM +0100, Konrad Dybcio wrote:
> > +&blsp_i2c3 {
> > + status = "okay";
> > +
> > + imu@68 {
> > + compatible = "bosch,bmi160";
> > + reg = <0x68>;
> > +
> > + vdd-supply = <&pm8916_l17>;
> > + vddio-supply = <&pm8916_l6>;
> > +
> > + mount-matrix = "0", "1", "0",
> > + "-1", "0", "0",
> > + "0", "0", "1";
> > + };
> > +
> > + magnetometer@d {
> > + compatible = "asahi-kasei,ak09911";
> > + reg = <0x0d>;
> > +
> > + vdd-supply = <&pm8916_l17>;
> > + vid-supply = <&pm8916_l6>;
> > +
> > + reset-gpios = <&msmgpio 111 GPIO_ACTIVE_LOW>;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mag_reset_default>;
> > + };
> > +};
>
> Please sort I2C devices by their address.
>
+1 :)
>
> > };
> >
> > + mag_reset_default: mag-reset-default {
> > + pins = "gpio111";
> > + function = "gpio";
> > +
> > + drive-strength = <2>;
> > + bias-disable;
> > + };
> > +
>
> Please add this after gpio110 to keep it sorted gpio-number-wise.
>
This is ordered alphabetically. I haven't seen gpio-number order
anywhere yet... :)
Thanks,
Stephan
next prev parent reply other threads:[~2021-01-24 15:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 13:54 [PATCH 0/3] Add initial support for BQ Aquaris X5 Jonathan Albrieux
2021-01-24 13:54 ` [PATCH 1/3] arm64: dts: qcom: Add device tree for BQ Aquaris X5 (Longcheer L8910) Jonathan Albrieux
2021-01-24 15:12 ` Konrad Dybcio
2021-01-24 15:45 ` Stephan Gerhold
2021-01-24 13:54 ` [PATCH 2/3] arm64: dts: qcom: msm8916: Add blsp_i2c3 Jonathan Albrieux
2021-01-24 15:09 ` Konrad Dybcio
2021-01-24 15:52 ` Stephan Gerhold
2021-01-24 13:54 ` [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer Jonathan Albrieux
2021-01-24 15:07 ` Konrad Dybcio
2021-01-24 15:51 ` Stephan Gerhold [this message]
2021-01-24 19:49 ` Jonathan Albrieux
2021-01-28 4:22 ` Bjorn Andersson
2021-01-24 21:01 ` [PATCH 0/3] Add initial support for BQ Aquaris X5 Pavel Machek
2021-01-24 21:49 ` Stephan Gerhold
2021-01-27 22:24 ` Pavel Machek
2021-01-28 9:27 ` Stephan Gerhold
2021-02-02 13:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA2Xg9PboDMc/vu1@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan.albrieux@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.