From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Nidhi Gupta <nidhi1.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: test requires eDP
Date: Mon, 25 Jan 2021 14:25:35 +0200 [thread overview]
Message-ID: <YA64v4C3f5rAyDV1@intel.com> (raw)
In-Reply-To: <20210125070336.15378-1-nidhi1.gupta@intel.com>
On Mon, Jan 25, 2021 at 12:33:36PM +0530, Nidhi Gupta wrote:
> Added a condition to check the availability of eDP
> before execution of the test. Skip the test with
> proper debug messsage if eDP is not there
>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_panel_fitting.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 4f4c5608..9f6b00e5 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -254,7 +254,10 @@ igt_main
> igt_fixture {
> data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> igt_display_require(&data.display, data.drm_fd);
> - igt_display_require_output(&data.display);
> +
> + if (data.display.outputs->config.connector->connector_type !=
> + DRM_MODE_CONNECTOR_eDP)
> + igt_skip("Can't test: no usable eDP screen.\n");
No, it just wants an output type where we've hooked up the pfit.
It already checks for that by looking for the scaling mode prop.
> }
>
> igt_subtest("legacy")
> --
> 2.26.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2021-01-25 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 7:03 [igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: test requires eDP Nidhi Gupta
2021-01-25 7:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-25 8:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-01-25 12:25 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA64v4C3f5rAyDV1@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nidhi1.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.