From: Stephan Gerhold <stephan@gerhold.net>
To: Jun Nie <jun.nie@linaro.org>
Cc: plai@codeaurora.org, bgoswami@codeaurora.org,
srinivas.kandagatla@linaro.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map
Date: Mon, 25 Jan 2021 11:30:19 +0100 [thread overview]
Message-ID: <YA6dsJTmVcv1TKBZ@gerhold.net> (raw)
In-Reply-To: <20210120024955.3911891-1-jun.nie@linaro.org>
On Wed, Jan 20, 2021 at 10:49:55AM +0800, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
Thanks for spotting this, I guess this did not cause me problems yet
because I use SNDRV_PCM_FMTBIT_S16 everywhere.
Anyway, this looks correct according to the datasheet:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> sound/soc/qcom/lpass-apq8016.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 8507ef8f6679..3efa133d1c64 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
> .micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
> .micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
> .wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> - .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> + .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>
> .rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
> .rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-01-25 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 2:49 [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map Jun Nie
2021-01-25 10:30 ` Stephan Gerhold [this message]
2021-01-25 11:01 ` Srinivas Kandagatla
2021-02-01 10:44 ` Stephan Gerhold
-- strict thread matches above, loose matches on Subject: below --
2021-02-01 13:29 Jun Nie
2021-02-05 20:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA6dsJTmVcv1TKBZ@gerhold.net \
--to=stephan@gerhold.net \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=jun.nie@linaro.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.