From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F1AC4332B for ; Tue, 26 Jan 2021 05:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C5C022ADF for ; Tue, 26 Jan 2021 05:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388062AbhAZFjT (ORCPT ); Tue, 26 Jan 2021 00:39:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727688AbhAYK5S (ORCPT ); Mon, 25 Jan 2021 05:57:18 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0B60C06178C for ; Mon, 25 Jan 2021 02:56:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tSVMd0mAlQmzss31L3fywYUpzOMWEDoUIO25DXKyPoY=; b=bziIHjbwox/9XclfRRt36f9DpG jr8lqfbZRMsDnxNG/n8/VSPzUjihDrzAI70R19fL37VhE0OV+pwGWeQQr7HWEo+DR7d0ytSt1H/7U 4rSZENlPy2F3CHQDlUrlTRPLWkUzr+ek10uD4oA/NhdnAOFg7QX3x3//LC7arnLNaoKoxaxtJQwgS jDxKgup2eYeqg5vh0cLRgY96A68X6LCzxQ8svIJKWKn3icDFrN7DZJ9ItvrX1DkVLCTPProM5tWLp gR3KLSpDnas/2XnuC55ttg8Lg6t7iT6+29WFBG2r68qAwVeznEKeu2xtzpuMyFD2yvW66iSdQaNy8 +dqzdL8Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3zXF-0002v4-Fy; Mon, 25 Jan 2021 10:55:53 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 682EB300DB4; Mon, 25 Jan 2021 11:55:51 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5025B28B66D19; Mon, 25 Jan 2021 11:55:51 +0100 (CET) Date: Mon, 25 Jan 2021 11:55:51 +0100 From: Peter Zijlstra To: Like Xu Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/perf: Use static_call for x86_pmu.guest_get_msrs Message-ID: References: <20210122030324.2754492-1-like.xu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210122030324.2754492-1-like.xu@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 11:03:24AM +0800, Like Xu wrote: > Clean up that CONFIG_RETPOLINE crud and replace the > indirect call x86_pmu.guest_get_msrs with static_call(). > Looks good in principle, but the robot complains about a missing func decl. I think you removed a little too much when you killed the inline thing.