From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE72C433E0 for ; Tue, 26 Jan 2021 06:54:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 969E622228 for ; Tue, 26 Jan 2021 06:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389096AbhAZGxa (ORCPT ); Tue, 26 Jan 2021 01:53:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729982AbhAYPfk (ORCPT ); Mon, 25 Jan 2021 10:35:40 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0196C061224 for ; Mon, 25 Jan 2021 07:23:05 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id h14so13053727otr.4 for ; Mon, 25 Jan 2021 07:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Lo7lv5OxxAFtMueqAJVGhFDn/LukUddIU2Fiy+gEQuI=; b=poLLy+034v97d/qsqdvFRNp6ftVN3OOuUAYS0xkwOOf+DYk39RRi0TCQ3ygJsx4su4 PjriCB2cfkatWbJMaNnz3vjVMx5hQ8e3DDBt+dQK6twLbvls5Br2ykNw1iF07JAPcK3q YD8C8PXHlvlT0QhZDJRMmCuWxwSZdwzwTE4Fn5HjByn9BUvz+wD9ywluI//upUkioE6F +Cnhjv0d57cVMGDX1qnVhPSljeiOh9fcw8NMcGIZSfbZSFNnqA/mKmXUj2iUwBuNH8Uf uEPhgDVvWzBt9cA+rCH475atw2tQWmD06uv2eXSVlJbc/LpYYszre6RITiU1qx/BOmcK onuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Lo7lv5OxxAFtMueqAJVGhFDn/LukUddIU2Fiy+gEQuI=; b=b3iR+nXPmCwyvO7nU2O3P7/dJ5lsSmytF+TqLJ/wGQNjuQWPLhPabb9k6Rf8V3Nbsq sZs4Oq1RumKNj9jvu7yUnmvYVb9O0W8qm9upbg8knNiRUECzZpa4AwWTqz+tW0ADL++8 PBy9FkRUzwy0BSaG9d6b/+7d+9FevAJN88w5YJgP5BVWFiCR13kCdcP6K3gn2P1oo9MD drnfgOaBYH7ISjewgUPgzXvjOM7p769PRP42+4G4wUwWWN8IpbeNy+jCrcHG1JvmVgkG IZ1jxu9CWDckOs7IJCZsy4mKVMb5wfBB9AGK1Hr1YKnYbBEoJSd+NDPkhTon6cLjaeLU hAFA== X-Gm-Message-State: AOAM533ktW/GoXJELFDT/rN44pbWU4RwulKGICV6zzmrZIh5JL5Qpc4w 4RzfOo3GH8HQ7AniAO2H93HtxSR3GTkK3A== X-Google-Smtp-Source: ABdhPJwsaz6kYv5Vz5E7CK/Izn6RArB6cWNzJaxLMm0/XF/bSXo+TCcgoT1Rjv4Yk8hqCXnA9fuzyA== X-Received: by 2002:a9d:3786:: with SMTP id x6mr818146otb.176.1611588184943; Mon, 25 Jan 2021 07:23:04 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id c26sm2560370otu.48.2021.01.25.07.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 07:23:04 -0800 (PST) Date: Mon, 25 Jan 2021 09:23:01 -0600 From: Bjorn Andersson To: Arnd Bergmann Cc: Alex Elder , "David S. Miller" , Jakub Kicinski , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] ipa: add remoteproc dependency Message-ID: References: <20210125113557.2388311-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210125113557.2388311-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compile-testing without CONFIG_REMOTEPROC results in a build failure: > > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > ld.lld: error: undefined symbol: rproc_put > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a > > Add a new dependency to avoid this. > Afaict this should be addressed by: 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency") which is present in linux-next. Regards, Bjorn > Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ipa/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index b68f1289b89e..aa1c0ae3cf01 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -3,6 +3,7 @@ config QCOM_IPA > depends on 64BIT && NET && QCOM_SMEM > depends on ARCH_QCOM || COMPILE_TEST > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > + depends on REMOTEPROC > select QCOM_MDT_LOADER if ARCH_QCOM > select QCOM_QMI_HELPERS > help > -- > 2.29.2 >