All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	Jonathan Tan <jonathantanmy@google.com>,
	Jeff King <peff@peff.net>, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2 0/3] Refactor writing promisor file
Date: Thu, 14 Jan 2021 12:23:42 -0500	[thread overview]
Message-ID: <YAB+Hu5/5NHUb/vw@nand.local> (raw)
In-Reply-To: <20210114155016.3005932-1-chriscool@tuxfamily.org>

On Thu, Jan 14, 2021 at 04:50:13PM +0100, Christian Couder wrote:
> Compared to version 1 of this patch series, the only difference is
> that patch 3/3 has been added to die() in case of error, instead of
> ignoring it, when actually writing the content of the file or closing
> it. Thanks to Peff and Taylor for their suggestions.

Thanks, this version looks good to me.

Thanks,
Taylor

  parent reply	other threads:[~2021-01-14 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 15:50 [PATCH v2 0/3] Refactor writing promisor file Christian Couder
2021-01-14 15:50 ` [PATCH v2 1/3] fetch-pack: rename helper to create_promisor_file() Christian Couder
2021-01-14 15:50 ` [PATCH v2 2/3] fetch-pack: refactor writing promisor file Christian Couder
2021-01-14 15:50 ` [PATCH v2 3/3] pack-write: die on error in write_promisor_file() Christian Couder
2021-01-14 17:23 ` Taylor Blau [this message]
2021-01-14 20:11 ` [PATCH v2 0/3] Refactor writing promisor file Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAB+Hu5/5NHUb/vw@nand.local \
    --to=me@ttaylorr.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.