From: Andrew Lunn <andrew@lunn.ch>
To: stefanc@marvell.com
Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com,
linux-kernel@vger.kernel.org, kuba@kernel.org,
linux@armlinux.org.uk, mw@semihalf.com,
rmk+kernel@armlinux.org.uk, atenart@kernel.org
Subject: Re: [PATCH net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err
Date: Thu, 14 Jan 2021 16:44:36 +0100 [thread overview]
Message-ID: <YABm5PDi94I5VKQp@lunn.ch> (raw)
In-Reply-To: <1610618858-5093-1-git-send-email-stefanc@marvell.com>
On Thu, Jan 14, 2021 at 12:07:38PM +0200, stefanc@marvell.com wrote:
> From: Stefan Chulski <stefanc@marvell.com>
>
> This patch doesn't change any functionality, but just extend
> MIB counter register and ethtool-statistic names with "err".
>
> The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter.
> Extend REG name and appropriated ethtool statistic reg-name
> with the ERR/err.
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -1566,7 +1566,7 @@ static u32 mvpp2_read_index(struct mvpp2 *priv, u32 index, u32 reg)
> { MVPP2_MIB_FC_RCVD, "fc_received" },
> { MVPP2_MIB_RX_FIFO_OVERRUN, "rx_fifo_overrun" },
> { MVPP2_MIB_UNDERSIZE_RCVD, "undersize_received" },
> - { MVPP2_MIB_FRAGMENTS_RCVD, "fragments_received" },
> + { MVPP2_MIB_FRAGMENTS_ERR_RCVD, "fragments_err_received" },
Hi Stefan
I suspect this is now ABI and you cannot change it. You at least need
to argue why it is not ABI.
Andrew
next prev parent reply other threads:[~2021-01-14 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 10:07 [PATCH net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err stefanc
2021-01-14 15:44 ` Andrew Lunn [this message]
2021-01-14 16:13 ` [EXT] " Stefan Chulski
2021-01-14 17:49 ` Jakub Kicinski
2021-01-14 18:20 ` Andrew Lunn
2021-01-14 17:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YABm5PDi94I5VKQp@lunn.ch \
--to=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.