From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: kmsg_dump: revert msg_print_text() workaround
Date: Thu, 14 Jan 2021 16:49:50 +0100 [thread overview]
Message-ID: <YABoHgNunkcfBElL@alley> (raw)
In-Reply-To: <20210114090511.17784-1-john.ogness@linutronix.de>
On Thu 2021-01-14 10:11:11, John Ogness wrote:
> The old msg_print_text() function only filled up to size-1 bytes of
> the buffer. A workaround for this quirky behavior was implemented
> with commit c9dccacfccc7 ("printk: Do not lose last line in kmsg
> buffer dump").
>
> However, with commit 896fbe20b4e2 ("printk: use the lockless
> ringbuffer"), msg_print_text() was replaced by,
> which will fill the full buffer. Therefore, the workaround is now
> incorrectly assuming less data can fit into the buffer. Revert the
> workaround.
We should make record_print_text() behave the same as msg_print_text()
behaved. There might be more users affected by this change and even
in userspace :-(
Let's discuss it in the other thread
https://lore.kernel.org/lkml/87im8038v7.fsf@jogness.linutronix.de/
Best Regards,
Petr
prev parent reply other threads:[~2021-01-14 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 9:05 [PATCH] printk: kmsg_dump: revert msg_print_text() workaround John Ogness
2021-01-14 15:49 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YABoHgNunkcfBElL@alley \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.