All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, pavana.sharma@digi.com,
	vivien.didelot@gmail.com, f.fainelli@gmail.com, kuba@kernel.org,
	lkp@intel.com, davem@davemloft.net, ashkan.boldaji@digi.com,
	Chris Packham <chris.packham@alliedtelesis.co.nz>,
	olteanv@gmail.com,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode
Date: Fri, 15 Jan 2021 00:00:33 +0100	[thread overview]
Message-ID: <YADNEWkiPQX34Tyo@lunn.ch> (raw)
In-Reply-To: <20210114024055.17602-1-kabel@kernel.org>

> diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
> index 3195936dc5be..b8241820679e 100644
> --- a/drivers/net/dsa/mv88e6xxx/serdes.c
> +++ b/drivers/net/dsa/mv88e6xxx/serdes.c
> @@ -55,9 +55,20 @@ static int mv88e6xxx_serdes_pcs_get_state(struct mv88e6xxx_chip *chip,
>  {
>  	if (status & MV88E6390_SGMII_PHY_STATUS_SPD_DPL_VALID) {
>  		state->link = !!(status & MV88E6390_SGMII_PHY_STATUS_LINK);
> +
> +		if (state->interface == PHY_INTERFACE_MODE_2500BASEX) {
> +			if (state->link) {
> +				state->speed = SPEED_2500;
> +				state->duplex = DUPLEX_FULL;
> +			}
> +
> +			return 0;
> +		}
> +
> +		state->an_complete = 1;

Should this be here? It seems like a logically different change, it is
not clear to me it is to do with PHY_INTERFACE_MODE_2500BASEX.

>  		state->duplex = status &
>  				MV88E6390_SGMII_PHY_STATUS_DUPLEX_FULL ?
> -			                         DUPLEX_FULL : DUPLEX_HALF;
> +						DUPLEX_FULL : DUPLEX_HALF;

This looks like an unintended white space change.

     Andrew

  reply	other threads:[~2021-01-14 23:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  2:40 [PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode Marek Behún
2021-01-14 23:00 ` Andrew Lunn [this message]
2021-01-14 23:55   ` Marek Behún
2021-01-15 14:16     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YADNEWkiPQX34Tyo@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ashkan.boldaji@digi.com \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kabel@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pavana.sharma@digi.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.