From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Caleb Connolly <caleb@connolly.tech>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] arm64: dts: sdm845: add oneplus6/6t devices
Date: Thu, 14 Jan 2021 21:54:11 -0600 [thread overview]
Message-ID: <YAER4xpcq0Rn9UgD@builder.lan> (raw)
In-Reply-To: <1b023774-d091-e7fd-8eaf-dedeff5feac2@somainline.org>
On Thu 14 Jan 14:33 CST 2021, Konrad Dybcio wrote:
>
> > The device definitely doesn't support USB3, although downstream does
> > leave the USB3 phy enabled the hardware doesn't support it. So it made
> > sense to disable it here.
>
>
> Sure.
>
>
> > OnePlus' bootloader doesn't seem to care about these values so I left
> > them out for simplicity.
>
> Sounds strange, but it's not the first time vendors surprise us.
>
This particular requirement seems to be rather random. Some board loads
a single dtb without these properties, others require them even for the
single, appended, case.
Regards,
Bjorn
next prev parent reply other threads:[~2021-01-15 3:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 18:53 [PATCH v3] Add support for the OnePlus 6 and 6T Caleb Connolly
2021-01-14 18:54 ` [PATCH v3 1/2] arm64: dts: sdm845: add oneplus6/6t devices Caleb Connolly
2021-01-14 19:19 ` Konrad Dybcio
2021-01-14 20:10 ` Caleb Connolly
2021-01-14 20:33 ` Konrad Dybcio
2021-01-15 3:54 ` Bjorn Andersson [this message]
2021-01-14 18:54 ` [PATCH v3 2/2] dt-bindings: Document bindings for new SDM845 devices Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAER4xpcq0Rn9UgD@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=anton@enomsg.org \
--cc=caleb@connolly.tech \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.