All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Chris Packham" <chris.packham@alliedtelesis.co.nz>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Ralph Sennhauser" <ralph.sennhauser@gmail.com>,
	linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] gpio: mvebu: fix pwm .get_state period calculation
Date: Fri, 15 Jan 2021 16:47:38 +0100	[thread overview]
Message-ID: <YAG40eoRhk3f1rlj@ulmo> (raw)
In-Reply-To: <57860e4929a9d20d73f5e003a148b86a9f82310e.1610529002.git.baruch@tkos.co.il>

On Wed, Jan 13, 2021 at 11:22:41AM +0200, Baruch Siach wrote:
> The period is the sum of on and off values. That is, calculate period as
> 
>   ($on + $off) / clkrate
> 
> instead of
> 
>   $off / clkrate - $on / clkrate
> 
> that makes no sense.
> 
> Reported-by: Russell King <linux@armlinux.org.uk>
> Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  drivers/gpio/gpio-mvebu.c | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)

Acked-by: Thierry Reding <thierry.reding@gmail.com>

  parent reply	other threads:[~2021-01-15 15:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  9:22 [PATCH v2 0/5] gpio: mvebu: pwm fixes and improvements Baruch Siach
2021-01-13  9:22 ` Baruch Siach
2021-01-13  9:22 ` [PATCH v2 1/5] gpio: mvebu: fix pwm .get_state period calculation Baruch Siach
2021-01-13  9:22   ` Baruch Siach
2021-01-13  9:27   ` Uwe Kleine-König
2021-01-13  9:27     ` Uwe Kleine-König
2021-01-15 15:47   ` Thierry Reding [this message]
2021-01-13  9:22 ` [PATCH v2 2/5] gpio: mvebu: improve pwm period calculation accuracy Baruch Siach
2021-01-13  9:22   ` Baruch Siach
2021-01-13  9:22 ` [PATCH v2 3/5] gpio: mvebu: make pwm .get_state closer to idempotent Baruch Siach
2021-01-13  9:22   ` Baruch Siach
2021-01-13  9:42   ` Uwe Kleine-König
2021-01-13  9:42     ` Uwe Kleine-König
2021-01-13  9:22 ` [PATCH v2 4/5] gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX Baruch Siach
2021-01-13  9:22   ` Baruch Siach
2021-01-13  9:22 ` [PATCH v2 5/5] gpio: mvebu: document zero pwm duty cycle limitation Baruch Siach
2021-01-13  9:22   ` Baruch Siach
2021-01-18 13:45 ` [PATCH v2 0/5] gpio: mvebu: pwm fixes and improvements Linus Walleij
2021-01-18 13:45   ` Linus Walleij
2021-01-18 14:59   ` Uwe Kleine-König
2021-01-18 14:59     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAG40eoRhk3f1rlj@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=baruch@tkos.co.il \
    --cc=bgolaszewski@baylibre.com \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=gregory.clement@bootlin.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ralph.sennhauser@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.