From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB28C433DB for ; Fri, 15 Jan 2021 14:20:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEFBC224F9 for ; Fri, 15 Jan 2021 14:20:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEFBC224F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Pxu-0006NU-KT for qemu-devel@archiver.kernel.org; Fri, 15 Jan 2021 09:20:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0PeR-0000yK-P8; Fri, 15 Jan 2021 09:00:31 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48387) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0PeO-0002Nt-Iu; Fri, 15 Jan 2021 09:00:31 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3E0505C01C4; Fri, 15 Jan 2021 09:00:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 15 Jan 2021 09:00:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=ojr991irad/SQ2jqVhFXW//2p8X toEnpBnuWj2/37XM=; b=FePk8bjf8dTA1ilpYd5ZW5r4EmAVFNJUFAkLC7QxGdr AUQT7VlPH5pYoSqLkU3v7lnYpPuUXrz/XJr5PZx4OvfVxsacu+nJz7/YMltdBV/b e4TlF4QvuiiDO72NaFVWr5Udiqjqm3i4AGEpk6maQX/dSV1gqQNUWn40O7u4I2qH tNBKdFZLumLInY9C4DEakZ7nbNwvSsWVndSYNOtEc9cTElM+LaU2tFV5gmbftfJs rlPqyEWSDVckptqxg6C/97t+0WrTXJcrjnk9zHFPfWoPIjSH1YuULKYYUbf7WIHf 6NJ86yeqHeM0Wh3q9CsUzpkIfSlVUoDmmrW+Ou8Ia5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ojr991 irad/SQ2jqVhFXW//2p8XtoEnpBnuWj2/37XM=; b=JHgq0gzhDi58a1pjzMPLlw Erw8UwYQTPOpnp9YWfIP4VvBO6vOSWrDeWYsi6PfMWE0B7KMAqVnzUIJ8Viz4Qv1 N4oTQlJG9t8tWQvDu4ofs67F3J27yhMQIcguZfTopCqk4gBQO4gHQnD3Fr1AGpMj ywcFHmXrG8+EpoTNnkGc88ZGtKZzbBIg3Fi4xeeVijwWhHtlQq9GC4Fr8tQtQUHF QAOY+r05BLrQZOZP6CfJluPLoVxO2j/0u5Wpb0Xf6omQXpBVneQCm7wdxZ1PXgto ADgktdBup4E0zffkCjJHUZWI1b7/Ay+EpuvoDRjRTlB8DEFWiGalttcuO0kIPu/g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtddvgdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghushcu lfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrthhtvg hrnhepjeegudffueeiteekieelkedvueelteevjeduieeludfffeejgeffhfduvdduffek necukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 8E8491080057; Fri, 15 Jan 2021 09:00:22 -0500 (EST) Date: Fri, 15 Jan 2021 15:00:20 +0100 From: Klaus Jensen To: Minwoo Im Subject: Re: [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str() Message-ID: References: <20210115134845.17618-1-minwoo.im.dev@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DTepGJfl2guxlbAd" Content-Disposition: inline In-Reply-To: <20210115134845.17618-1-minwoo.im.dev@gmail.com> Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --DTepGJfl2guxlbAd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jan 15 22:48, Minwoo Im wrote: > Currently, Zoned I/O commands are parsed as unknown: > pci_nvme_io_cmd cid 768 nsid 1 sqid 4 opc 0x79 opname 'NVME_NVM_CMD_UNK= NOWN' >=20 > Parse zoned I/O commands along with other I/O commands to print. >=20 > Signed-off-by: Minwoo Im > --- > hw/block/nvme.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/hw/block/nvme.h b/hw/block/nvme.h > index b7fbcca39d9f..0c1cb6fd2549 100644 > --- a/hw/block/nvme.h > +++ b/hw/block/nvme.h > @@ -66,6 +66,9 @@ static inline const char *nvme_io_opc_str(uint8_t opc) > case NVME_CMD_READ: return "NVME_NVM_CMD_READ"; > case NVME_CMD_WRITE_ZEROES: return "NVME_NVM_CMD_WRITE_ZEROES"; > case NVME_CMD_DSM: return "NVME_NVM_CMD_DSM"; > + case NVME_CMD_ZONE_MGMT_SEND: return "NVME_NVM_CMD_ZONE_MGMT_SEND"; > + case NVME_CMD_ZONE_MGMT_RECV: return "NVME_NVM_CMD_ZONE_MGMT_RECV"; > + case NVME_CMD_ZONE_APPEND: return "NVME_NVM_CMD_ZONE_APPEND"; > default: return "NVME_NVM_CMD_UNKNOWN"; > } > } > --=20 > 2.17.1 >=20 I have this in a series under review. Compare is also missing ;) "[PATCH 5/6] hw/block/nvme: add missing string representations for commands" --DTepGJfl2guxlbAd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmABn/MACgkQTeGvMW1P DenJzwf+PZwC8zZlllf1zQw6RZ38RI8GvgFISzaDULWa1ybY0OexJkW8TJwj5RaW ghYXmo2+X35+eSJHTfe883HhQTxeuPjruzwHLWjHdUh49nqIbJ5pRTWSu94a7/sr iafYwIL9t5yjQyzmwCS7yPkjqAgIhi+d0+waKMDiKguquajUXbyfaOsk/CYEgz9E l52q8eMCOvWNwtlM7fJgwYR7S/OseahUZxaHU9hiK+fL4O6juhBw7QVrVLf4nG+z DT7Naqs7J/bydULKuyo3OOI7ZEX0hMKasnHRWsZ2M7947HI6yHJ8VhLh/KeCs+E+ lMXBDYSVEIzhcHWHKOFUkZUZ5D9Z9A== =2aMq -----END PGP SIGNATURE----- --DTepGJfl2guxlbAd--