From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF5AC433E0 for ; Fri, 15 Jan 2021 14:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ED4523370 for ; Fri, 15 Jan 2021 14:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728292AbhAOOzt (ORCPT ); Fri, 15 Jan 2021 09:55:49 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:42848 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbhAOOzs (ORCPT ); Fri, 15 Jan 2021 09:55:48 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l0QVG-000lNp-Gs; Fri, 15 Jan 2021 15:55:06 +0100 Date: Fri, 15 Jan 2021 15:55:06 +0100 From: Andrew Lunn To: Marek Vasut Cc: netdev@vger.kernel.org, Heiner Kallweit , Lukas Wunner Subject: Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY Message-ID: References: <20210111125337.36513-1-marex@denx.de> <268090ca-06dd-d7e2-c06b-b9282f3cbe67@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <268090ca-06dd-d7e2-c06b-b9282f3cbe67@denx.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > > I noticed a couple of drivers implement both the mii and mdiobus options. > > > > Which ones? > > boardcom b44.c and bcm63xx_enet.c for example Thanks. I will take a look at those and maybe ask Florian. > > Simply getting the link status might be safe, but if > > set_link_ksettings() or get_link_ksettings() is used, phylib is going > > to get confused when the PHY is changed without it knowing.. So please > > do remove all the mii calls as part of the patchset. > > Isn't that gonna break some ABI ? I guess not, but i have no definitive answer. It should add more features, not take any away. > Also, is separate patch OK ? It obviously works well enough that you have not run into issues. So i guess anybody doing a git bisect will be O.K. if they land on the state with both phydev and mii. So yes, a separate patch is O.K. Andrew