Re: [PATCH v2 3/3] gemalto: netmon measurements scaling

[Sergey Matyukevich <geomatsi@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hello Denis,

> > Gemalto modem reports raw measurements in dBm. Reported values may
> > include negative numbers. Meanwhile oFono follows ETSI TS 27.007,
> > so negative numbers do not really exist at the API level.
> > 
> > Modify gemalto netmon driver to report measurements according to
> > 27.007. For this purpose re-scale from what Gemalto firmware
> > reports into something that 27.007 recommends.
> > ---
> >   drivers/gemaltomodem/netmon.c | 52 ++++++++++++++++++++++++++++++++---
> >   1 file changed, 48 insertions(+), 4 deletions(-)
> > 
> 
> I went ahead and applied all three patches after making minor tweaks in this one:

Thanks!

> > +static int gemalto_rscp_scale(int value)
> > +{
> > +	if (value < -120)
> > +		return 0;
> > +
> > +	if (value > -24)
> > +		return 96;
> > +
> > +	return (value + 120);
> 
> The ()s weren't needed here..

Well, I did check coding style document for arithmetic expressions,
but I did not find anything other than spaces around operators. 
So I made a wrong guess...

Regards,
Sergey