From: Greg KH <gregkh@linuxfoundation.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, trix@redhat.com,
lgoncalv@redhat.com, hao.wu@intel.com
Subject: Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices
Date: Sun, 17 Jan 2021 16:45:04 +0100 [thread overview]
Message-ID: <YARbgGU6lr3zZaKP@kroah.com> (raw)
In-Reply-To: <1610502848-30345-2-git-send-email-yilun.xu@intel.com>
On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote:
> This patch supports the DFL drivers be written in userspace. This is
> realized by exposing the userspace I/O device interfaces.
>
> The driver leverages the uio_pdrv_genirq, it adds the uio_pdrv_genirq
> platform device with the DFL device's resources, and let the generic UIO
> platform device driver provide support to userspace access to kernel
> interrupts and memory locations.
Why doesn't the existing uio driver work for this, why do you need a new
one?
> ---
> drivers/fpga/Kconfig | 10 +++++
> drivers/fpga/Makefile | 1 +
> drivers/fpga/dfl-uio-pdev.c | 93 +++++++++++++++++++++++++++++++++++++++++++++
uio drivers traditionally go in drivers/uio/ and start with "uio", so
shouldn't this be drivers/uio/uio_dfl_pdev.c to match the same naming
scheme?
But again, you need to explain in detail, why the existing uio driver
doesn't work properly, or why you can't just add a few lines to an
existing one.
thanks,
greg k-h
next prev parent reply other threads:[~2021-01-17 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 1:54 [PATCH v6 0/2] UIO support for dfl devices Xu Yilun
2021-01-13 1:54 ` [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices Xu Yilun
2021-01-17 3:56 ` Moritz Fischer
2021-01-18 2:48 ` Xu Yilun
2021-01-17 15:45 ` Greg KH [this message]
2021-01-17 16:22 ` Moritz Fischer
2021-01-21 14:30 ` Tom Rix
2021-01-21 20:03 ` Moritz Fischer
2021-01-22 5:46 ` Xu Yilun
2021-01-13 1:54 ` [PATCH v6 2/2] Documentation: fpga: dfl: Add description for DFL UIO support Xu Yilun
2021-01-17 3:57 ` Moritz Fischer
2021-01-18 3:10 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YARbgGU6lr3zZaKP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.