From: Potnuri Bharat Teja <bharat@chelsio.com>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value
Date: Mon, 18 Jan 2021 22:31:54 +0530 [thread overview]
Message-ID: <YAW/AseJZpaL2/RY@chelsio.com> (raw)
In-Reply-To: <20210114191423.423529-1-kamalheib1@gmail.com>
On Friday, January 01/15/21, 2021 at 00:44:23 +0530, Kamal Heib wrote:
> The max_recv_sge value is wrongly reported when calling query_qp, This
> is happening due to a typo when assigning the max_recv_sge value, the
> value of sq_max_sges was assigned instead of rq_max_sges.
>
> Fixes: 3e5c02c9ef9a ("iw_cxgb4: Support query_qp() verb")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
Thanks for the patch Kamal.
Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
> drivers/infiniband/hw/cxgb4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
> index a7401398cb34..d109bb3822a5 100644
> --- a/drivers/infiniband/hw/cxgb4/qp.c
> +++ b/drivers/infiniband/hw/cxgb4/qp.c
> @@ -2474,7 +2474,7 @@ int c4iw_ib_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
> init_attr->cap.max_send_wr = qhp->attr.sq_num_entries;
> init_attr->cap.max_recv_wr = qhp->attr.rq_num_entries;
> init_attr->cap.max_send_sge = qhp->attr.sq_max_sges;
> - init_attr->cap.max_recv_sge = qhp->attr.sq_max_sges;
> + init_attr->cap.max_recv_sge = qhp->attr.rq_max_sges;
> init_attr->cap.max_inline_data = T4_MAX_SEND_INLINE;
> init_attr->sq_sig_type = qhp->sq_sig_all ? IB_SIGNAL_ALL_WR : 0;
> return 0;
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-01-18 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 19:14 [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value Kamal Heib
2021-01-18 17:01 ` Potnuri Bharat Teja [this message]
2021-01-19 0:17 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAW/AseJZpaL2/RY@chelsio.com \
--to=bharat@chelsio.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.