All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Al Cooper <alcooperx@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	devicetree@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver
Date: Mon, 18 Jan 2021 18:45:40 +0100	[thread overview]
Message-ID: <YAXJRDhS1HXeYaZz@kroah.com> (raw)
In-Reply-To: <20210115211543.33563-3-alcooperx@gmail.com>

On Fri, Jan 15, 2021 at 04:15:43PM -0500, Al Cooper wrote:
> Add a UART driver for the new Broadcom 8250 based STB UART. The new
> UART is backward compatible with the standard 8250, but has some
> additional features. The new features include a high accuracy baud
> rate clock system and DMA support.
> 
> The driver will use the new optional BAUD MUX clock to select the best
> one of the four master clocks (81MHz, 108MHz, 64MHz and 48MHz) to feed
> the baud rate selection logic for any requested baud rate.  This allows
> for more accurate BAUD rates when high speed baud rates are selected.
> 
> The driver will use the new UART DMA hardware if the UART DMA registers
> are specified in Device Tree "reg" property. The DMA functionality can
> be disabled on kernel boot with the argument:
> "8250_bcm7271.disable_dma=Y".

Shouldn't that be on a per-device basis, and not a per-driver basis?

And why would you want to disable this, if you have support for this in
the DT?  Why not just rely on the DT setting?

thanks,

greg k-h

  reply	other threads:[~2021-01-18 17:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 21:15 [PATCH v2 0/2] serial: 8250: Add driver for Broadcom UART Al Cooper
2021-01-15 21:15 ` [PATCH v2 1/2] dt-bindings: Add support for the Broadcom UART driver Al Cooper
2021-01-17 15:45   ` Rob Herring
2021-01-15 21:15 ` [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver Al Cooper
2021-01-18 17:45   ` Greg Kroah-Hartman [this message]
2021-01-18 20:32     ` Al Cooper
2021-01-19 12:33       ` Greg Kroah-Hartman
2021-01-19 15:21   ` Andy Shevchenko
2021-01-19 18:16     ` Florian Fainelli
2021-01-20 16:47       ` Andy Shevchenko
2021-01-20 17:05         ` Greg Kroah-Hartman
2021-01-20 17:09           ` Andy Shevchenko
2021-01-20 17:15             ` Greg Kroah-Hartman
2021-01-20 17:30         ` Al Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAXJRDhS1HXeYaZz@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.