From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1l1qiK-0001ew-M9 for mharc-grub-devel@gnu.org; Tue, 19 Jan 2021 08:06:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1qiF-0001dA-0K for grub-devel@gnu.org; Tue, 19 Jan 2021 08:06:23 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:39651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1qiC-0006X3-9J for grub-devel@gnu.org; Tue, 19 Jan 2021 08:06:22 -0500 Received: by mail-wr1-x435.google.com with SMTP id c5so19657571wrp.6 for ; Tue, 19 Jan 2021 05:06:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=6ajP5pGkdwG6XucYPQDYFU500GzXeQov12ohuSHclos=; b=HfLXQkKqgDa2jVuMmd94DO0q/hzdlqKzbuTPUm1k5FcYFqcBIryopqG7+RLh77TFVP ov8EoKIbL1lsmNYaTZ+b2HQ13+BV+3DSORoAd085VqPCP1792Vx9g6Tgqf+OGBq+EX0q Ow3pvQL0p6x5aKGWhTu9T+V9VM15Q0Z3Li+JTxRiVjWardahDx62heO2qv1AMvxft4yh mPX/sY5wK0XAqYfhLcQB4Bj1gNfXv4Bijf7vDT11MQN3d6zsQYdTRtrur6EVrrvRqyJ0 12VaYwuYwnIzNvmjBlc4gVxjRgxN/QI5XDsPHcAbLVBQUtzzWA20LnwDjmkzOW/i793k APwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=6ajP5pGkdwG6XucYPQDYFU500GzXeQov12ohuSHclos=; b=LkZd8G0mmkTNgZUu7Ow5GSFbrCHifNK8zYoOHSkH3eOjyKyRcPYaZeO/pufSUJeOzA GvNmypOO3L74LW5Fmtbg8f440HuDDzNDApo+b78l6X100m3+In9d2puctLZty9/rMOFh 9WkB2kEeDKi5H7wm2iimupjUkceh1mgxHFKHJ6tPnwOL5L1s5JrwgEtqcqClLBJiDfqi NRQ/dwc+Gzlxl/roeAD62DEus+1AwXd7ZjL1OgA6j65xM5+jQN36pViiMuFNEGBH5JIA zv/qD73yChPe+odjHGYcZw1a7gvyNPe6KG6ueBmBF5sQ4lDlZPvIVXkS8yfZDlnNpJLt oxkw== X-Gm-Message-State: AOAM533FfHdWipP5pzqTXuqdAVa7obKAS/y1ykpKfhTLtLtrvPUZUn9u KZcaDOyGmScEJcq5IKD3nGA= X-Google-Smtp-Source: ABdhPJyso6hSygHbcoEd9DljV+6rRv2QYwuRE+mUBwGuPufbWYWbCyhCYC70O4/FpURlIPeot/ahRA== X-Received: by 2002:adf:e4ca:: with SMTP id v10mr4402089wrm.260.1611061578703; Tue, 19 Jan 2021 05:06:18 -0800 (PST) Received: from pevik ([62.201.25.198]) by smtp.gmail.com with ESMTPSA id g184sm4565654wma.16.2021.01.19.05.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 05:06:17 -0800 (PST) Date: Tue, 19 Jan 2021 14:06:15 +0100 From: Petr Vorel To: Dmitry Cc: The development of GNU GRUB , Patrick Steinhardt , Daniel Kiper Subject: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup Message-ID: Reply-To: Petr Vorel References: <20210119000758.GA178434@pevik> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=petr.vorel@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 13:06:24 -0000 Hi, > Please try to build only for the "efi-64" platform. (not "pc") right, I'll test it, but we need to support also legacy bios. BTW as Argon2 is the default PBKDF algorithm in current cryptsetup, Debian installer (and probably other distros' installers) uses it and it has to be converted after installation with Live CD / connecting HDD on different machine. Therefore postponing Argon2 to another release means users will have it in 2+ years after 2.06 release (unless distros backport it). Kind regards, Petr > Dmitry > вт, 19 янв. 2021 г. в 03:08, Petr Vorel : > > Hi Patrick, > > I know that this patchset needs some changes and is not planned to be included > > in 2.06. But anyway, testing it I found: > > ... > > > +++ b/grub-core/lib/argon2/core.c > > > +/* for explicit_bzero() on glibc */ > > > +#define _DEFAULT_SOURCE > > ... > > > +#if defined(__OpenBSD__) > > > +#define HAVE_EXPLICIT_BZERO 1 > > > +#elif defined(__GLIBC__) && defined(__GLIBC_PREREQ) > > > +#if __GLIBC_PREREQ(2,25) > > > +#define HAVE_EXPLICIT_BZERO 1 > > > +#endif > > Does this work? I get: > > grub-core/lib/argon2/core.c: In function ‘secure_wipe_memory’: > > grub-core/lib/argon2/core.c:135:5: error: implicit declaration of function ‘explicit_bzero’ [-Werror=implicit-function-declaration] > > 135 | explicit_bzero(v, n); > > Including isn't obviously a good idea. > > What's wrong? I have to miss something obvious. > > > +#endif > > If I remove HAVE_EXPLICIT_BZERO definition, I get errors when generating > > moddep.lst: > > make[3]: Entering directory '/home/pevik/install/src/grub.git/grub-core' > > cat syminfo.lst | sort | gawk -f ./genmoddep.awk > moddep.lst || (rm -f moddep.lst; exit 1) > > __moddi3 in argon2 is not defined > > __umoddi3 in argon2 is not defined > > My config-util.h does not have HAVE___MODDI3 and HAVE___UMODDI3. > > What's wrong? > > I'm compiling on recent distro. > > Thanks for any hint. > > Kind regards, > > Petr