From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A04C433DB for ; Tue, 19 Jan 2021 20:00:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27B712310B for ; Tue, 19 Jan 2021 20:00:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27B712310B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 757B26E02B; Tue, 19 Jan 2021 20:00:35 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id C90176E884; Tue, 19 Jan 2021 19:41:43 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2375922AAA; Tue, 19 Jan 2021 19:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611085303; bh=TnO8ugrL48XJWa3g2ivpjW9IGaxfuzLgSivb6haGxSI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fCuoFvqxwF3jwgzRIl992WtFbHrECE5onOMaHYlH20ANmvVHcgV+bnWugwew1P7Ad 8nBKq1cdLoiQ5B7/doMTSZltIZaOR2R4NODIbtZS3O7Dx/ObqXRxXzwFL0/NxxLtH5 RAY03hgFxQBW+CN1VbkvpitvivyWbSDw1l03OoQk= Date: Tue, 19 Jan 2021 20:41:40 +0100 From: Greg KH To: Alex Deucher Subject: Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr Message-ID: References: <1611003683-3534-1-git-send-email-andrey.grodzovsky@amd.com> <1611003683-3534-11-git-send-email-andrey.grodzovsky@amd.com> <3650d98a-2d73-06b8-7f06-ca7728b5c4b5@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Tue, 19 Jan 2021 20:00:33 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Grodzovsky , Daniel Vetter , amd-gfx list , Maling list - DRI developers , Christian =?iso-8859-1?Q?K=F6nig?= , "Deucher, Alexander" , Qiang Yu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Jan 19, 2021 at 02:04:48PM -0500, Alex Deucher wrote: > On Tue, Jan 19, 2021 at 1:26 PM Greg KH wrote: > > > > On Tue, Jan 19, 2021 at 11:36:01AM -0500, Andrey Grodzovsky wrote: > > > > > > On 1/19/21 2:34 AM, Greg KH wrote: > > > > On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote: > > > > > static struct pci_driver amdgpu_kms_pci_driver = { > > > > > .name = DRIVER_NAME, > > > > > .id_table = pciidlist, > > > > > @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = { > > > > > .shutdown = amdgpu_pci_shutdown, > > > > > .driver.pm = &amdgpu_pm_ops, > > > > > .err_handler = &amdgpu_pci_err_handler, > > > > > + .driver.dev_groups = amdgpu_sysfs_groups, > > > > Shouldn't this just be: > > > > groups - amdgpu_sysfs_groups, > > > > > > > > Why go to the "driver root" here? > > > > > > > > > Because I still didn't get to your suggestion to propose a patch to add groups to > > > pci_driver, it's located in 'base' driver struct. > > > > You are a pci driver, you should never have to mess with the "base" > > driver struct. Look at commit 92d50fc1602e ("PCI/IB: add support for > > pci driver attribute groups") which got merged in 4.14, way back in > > 2017 :) > > Per the previous discussion of this patch set: > https://www.mail-archive.com/amd-gfx@lists.freedesktop.org/msg56019.html Hey, at least I'm consistent :) _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6F5C433DB for ; Tue, 19 Jan 2021 19:41:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC3E922DD3 for ; Tue, 19 Jan 2021 19:41:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC3E922DD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13ED86E241; Tue, 19 Jan 2021 19:41:46 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id C90176E884; Tue, 19 Jan 2021 19:41:43 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2375922AAA; Tue, 19 Jan 2021 19:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611085303; bh=TnO8ugrL48XJWa3g2ivpjW9IGaxfuzLgSivb6haGxSI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fCuoFvqxwF3jwgzRIl992WtFbHrECE5onOMaHYlH20ANmvVHcgV+bnWugwew1P7Ad 8nBKq1cdLoiQ5B7/doMTSZltIZaOR2R4NODIbtZS3O7Dx/ObqXRxXzwFL0/NxxLtH5 RAY03hgFxQBW+CN1VbkvpitvivyWbSDw1l03OoQk= Date: Tue, 19 Jan 2021 20:41:40 +0100 From: Greg KH To: Alex Deucher Subject: Re: [PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr Message-ID: References: <1611003683-3534-1-git-send-email-andrey.grodzovsky@amd.com> <1611003683-3534-11-git-send-email-andrey.grodzovsky@amd.com> <3650d98a-2d73-06b8-7f06-ca7728b5c4b5@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , amd-gfx list , Maling list - DRI developers , Christian =?iso-8859-1?Q?K=F6nig?= , "Deucher, Alexander" , Qiang Yu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 19, 2021 at 02:04:48PM -0500, Alex Deucher wrote: > On Tue, Jan 19, 2021 at 1:26 PM Greg KH wrote: > > > > On Tue, Jan 19, 2021 at 11:36:01AM -0500, Andrey Grodzovsky wrote: > > > > > > On 1/19/21 2:34 AM, Greg KH wrote: > > > > On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote: > > > > > static struct pci_driver amdgpu_kms_pci_driver = { > > > > > .name = DRIVER_NAME, > > > > > .id_table = pciidlist, > > > > > @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = { > > > > > .shutdown = amdgpu_pci_shutdown, > > > > > .driver.pm = &amdgpu_pm_ops, > > > > > .err_handler = &amdgpu_pci_err_handler, > > > > > + .driver.dev_groups = amdgpu_sysfs_groups, > > > > Shouldn't this just be: > > > > groups - amdgpu_sysfs_groups, > > > > > > > > Why go to the "driver root" here? > > > > > > > > > Because I still didn't get to your suggestion to propose a patch to add groups to > > > pci_driver, it's located in 'base' driver struct. > > > > You are a pci driver, you should never have to mess with the "base" > > driver struct. Look at commit 92d50fc1602e ("PCI/IB: add support for > > pci driver attribute groups") which got merged in 4.14, way back in > > 2017 :) > > Per the previous discussion of this patch set: > https://www.mail-archive.com/amd-gfx@lists.freedesktop.org/msg56019.html Hey, at least I'm consistent :) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel