From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
"Linux Memory Management List" <linux-mm@kvack.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-media@vger.kernel.org,
"Kévin L'hôpital" <kevin.lhopital@bootlin.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>
Subject: Re: [linux-next:master 2460/4407] drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR'
Date: Wed, 20 Jan 2021 11:43:57 +0100 [thread overview]
Message-ID: <YAgJbe/7VymnpFIZ@aptenodytes> (raw)
In-Reply-To: <20210119185750.GO2696@kadam>
[-- Attachment #1: Type: text/plain, Size: 2855 bytes --]
Hi,
On Tue 19 Jan 21, 21:57, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: b4bb878f3eb3e604ebfe83bbc17eb7af8d99cbf4
> commit: 11c0d8fdccc56fa15cb15906480b4737c31dd085 [2460/4407] media: i2c: Add support for the OV8865 image sensor
> config: i386-randconfig-m021-20210119 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR'
Thanks, this was already reported and the fix is on its way :)
Cheers,
Paul
> vim +/PTR_ERR +2852 drivers/media/i2c/ov8865.c
>
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2840 /* DOVDD: digital I/O */
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2841 sensor->dovdd = devm_regulator_get(dev, "dovdd");
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2842 if (IS_ERR(sensor->dvdd)) {
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2843 dev_err(dev, "cannot get DOVDD (digital I/O) regulator\n");
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2844 ret = PTR_ERR(sensor->dvdd);
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2845 goto error_endpoint;
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2846 }
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2847
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2848 /* AVDD: analog */
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2849 sensor->avdd = devm_regulator_get(dev, "avdd");
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2850 if (IS_ERR(sensor->avdd)) {
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2851 dev_err(dev, "cannot get AVDD (analog) regulator\n");
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 @2852 ret = PTR_ERR(sensor->dvdd);
>
> typo. s/dvdd/avdd/.
>
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2853 goto error_endpoint;
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2854 }
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2855
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2856 /* External Clock */
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2857
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2858 sensor->extclk = devm_clk_get(dev, NULL);
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2859 if (IS_ERR(sensor->extclk)) {
> 11c0d8fdccc56fa1 Paul Kocialkowski 2020-12-31 2860 dev_err(dev, "failed to get external clock\n");
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-20 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 18:57 [linux-next:master 2460/4407] drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR' Dan Carpenter
2021-01-19 18:57 ` Dan Carpenter
2021-01-19 18:57 ` Dan Carpenter
2021-01-20 10:43 ` Paul Kocialkowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-19 12:39 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAgJbe/7VymnpFIZ@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=kevin.lhopital@bootlin.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.