From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SC8180x
Date: Wed, 20 Jan 2021 23:47:32 -0600 [thread overview]
Message-ID: <YAkVdOmy0MTeRQhz@builder.lan> (raw)
In-Reply-To: <20210120223556.1610214-2-bjorn.andersson@linaro.org>
On Wed 20 Jan 16:35 CST 2021, Bjorn Andersson wrote:
> diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c
[..]
> +static struct gdsc emac_gdsc = {
> + .gdscr = 0x106004,
Seems like I missed squashing the fixup where I subtract the gcc base
address after migrating these from the downstream dts.
As written the platform doesn't boot.
Please let me know if there's any other feedback before I respin v2.
Regards,
Bjorn
> + .pd = {
> + .name = "emac_gdsc",
> + },
> + .pwrsts = PWRSTS_OFF_ON,
> + .flags = POLL_CFG_GDSCR,
> +};
next prev parent reply other threads:[~2021-01-21 5:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 22:35 [PATCH 1/2] dt-bindings: clock: Add SC8180x GCC binding Bjorn Andersson
2021-01-20 22:35 ` [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SC8180x Bjorn Andersson
2021-01-21 5:47 ` Bjorn Andersson [this message]
2021-03-01 19:59 ` [PATCH 1/2] dt-bindings: clock: Add SC8180x GCC binding patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAkVdOmy0MTeRQhz@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.