Re: [oe] [meta-oe][dunfell][PATCH] rapidjson: Upgrade SRCREV to latest

["Mikko Rapeli" <mikko.rapeli@bmw.de>]

Hi,

On Wed, Jan 20, 2021 at 11:29:52AM +0530, Harpritkaur Bhandari wrote:
> Upgrade SRCREV to latest as it fixes the below issue:
> Running UndefinedBehaviorSanitizer on projects that use
> rapidjson triggers 'applying non-zero offset <NN> to null
> pointer' findings in 'internal/stack.h' which are hard
> to suppress by library users.
> Removed "0001-CMake-remove-hardcoded-CMAKECONFIG_INSTALL_DIR-path.patch"
> as the changes are already incorporated in the latest
> codebase.
> As per abi-compliance-checker report the source compatibility
> and binary compatibility between previous SRCREV
> 6a905f9311f82d306da77bd963ec5aa5da07da9c and current
> SRCREV 0ccdbf364c577803e2a751f5aededce935314313
> is 100% and this patch is already tested on 64bit
> ARM (aarch64) in a product with on target CI tests.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> (cherry picked from commit 04d9ea0ba7ece968244bf049893dd5636675b76f)
> Signed-off-by: Harpritkaur Bhandari <Harpritkaur.Bhandari@kpit.com>
> ---
>  meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb b/meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb
> index e3ed9c6..5b5c8b2 100644
> --- a/meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb
> +++ b/meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb
> @@ -4,10 +4,9 @@ SECTION = "libs"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://license.txt;md5=ba04aa8f65de1396a7e59d1d746c2125"
> 
> -SRC_URI = "git://github.com/miloyip/rapidjson.git;nobranch=1 \
> -           file://0001-CMake-remove-hardcoded-CMAKECONFIG_INSTALL_DIR-path.patch"

Please also remove the patch file. Also from master branch if it's still there
but no longer applied.

Cheers,

-Mikko

> +SRC_URI = "git://github.com/miloyip/rapidjson.git;nobranch=1"
> 
> -SRCREV = "6a905f9311f82d306da77bd963ec5aa5da07da9c"
> +SRCREV = "0ccdbf364c577803e2a751f5aededce935314313"
> 
>  PV = "1.1.0+git${SRCPV}"
> 
> --
> 2.7.4
> 
> This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.

> 
> 
>