Re: [PATCH v2] keys: X.509 public key issuer lookup without AKID

[Jarkko Sakkinen <jarkko@kernel.org>]

On Thu, Jan 21, 2021 at 12:31:59PM +0100, Andrew Zaborowski wrote:
> On Wed, 20 Jan 2021 at 02:57, Jarkko Sakkinen <jarkko@kernel.org> wrote:
> > On Fri, Jan 15, 2021 at 11:40:18AM +0100, Andrew Zaborowski wrote:
> > > Note: asymmetric_match_key_ids can be used as part of a generic key
> > > API query, or as part of a find_asymmetric_key call (only used in
> > > crypto/asymmetric_keys/ for trust verification and similar) but
> > > find_asymmetric_key will then perform an extra check.  In any case
> > > without more background I think it's preferable to minimize the
> > > matching logic changes, and even assuming that the logic could be
> > > improved it may be best to keep it as is because existing tools may
> > > rely on it.
> >
> > You could give a couple of usage examples, by using this cert
> >
> > https://letsencrypt.org/docs/certificates-for-localhost/
> >
> > That is good information to store in the commit log for future and
> > also works as a tested-by criteria.
> 
> Ok, resending the patch rebased on top of the BUG_ON fix (applied
> locally) and adding the command line example.
> 
> Best regards

Please make it a patch set then. Locally applied patches do not
count.

/Jarkko