From: Minchan Kim <minchan@kernel.org>
To: vjitta@codeaurora.org
Cc: glider@google.com, akpm@linux-foundation.org,
dan.j.williams@intel.com, broonie@kernel.org,
mhiramat@kernel.org, linux-kernel@vger.kernel.org,
ylal@codeaurora.org, vinmenon@codeaurora.org
Subject: Re: [PATCH v5 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE
Date: Thu, 21 Jan 2021 16:19:22 -0800 [thread overview]
Message-ID: <YAoaCqvRHILKp3w6@google.com> (raw)
In-Reply-To: <1610963802-11042-1-git-send-email-vjitta@codeaurora.org>
On Mon, Jan 18, 2021 at 03:26:41PM +0530, vjitta@codeaurora.org wrote:
> From: Yogesh Lal <ylal@codeaurora.org>
>
> Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.
>
> Aim is to have configurable value for STACK_HASH_SIZE,
> so depend on use case one can configure it.
>
> One example is of Page Owner, default value of
> STACK_HASH_SIZE lead stack depot to consume 8MB of static memory.
> Making it configurable and use lower value helps to enable features like
> CONFIG_PAGE_OWNER without any significant overhead.
The description could be improved to prevent confusing.
CONFIG_PAGE_OWNER works only if page_owner=on via kernel parameter
on CONFIG_PAGE_OWNER configured system.
Thus, unless admin enable it via command line option, the stackdepot
will just waste 8M memory without any customer.
>
> Signed-off-by: Yogesh Lal <ylal@codeaurora.org>
> Signed-off-by: Vinayak Menon <vinmenon@codeaurora.org>
> Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org>
Reviewed-by: Minchan Kim <minchan@kernel.org>
next prev parent reply other threads:[~2021-01-22 0:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 9:56 [PATCH v5 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE vjitta
2021-01-18 9:56 ` [PATCH v5 2/2] lib: stackdepot: Add support to disable stack depot vjitta
2021-01-22 0:25 ` Minchan Kim
2021-01-22 4:03 ` Vijayanand Jitta
2021-01-18 22:53 ` [PATCH v5 1/2] lib: stackdepot: Add support to configure STACK_HASH_SIZE Randy Dunlap
2021-01-18 22:53 ` Randy Dunlap
2021-01-19 6:52 ` Vijayanand Jitta
2021-01-19 6:52 ` Vijayanand Jitta
2021-01-19 6:54 ` Randy Dunlap
2021-01-19 6:54 ` Randy Dunlap
2021-01-22 8:54 ` Alexander Potapenko
2021-01-22 8:54 ` Alexander Potapenko
2021-01-22 0:19 ` Minchan Kim [this message]
2021-01-22 4:00 ` Vijayanand Jitta
2021-01-22 8:48 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAoaCqvRHILKp3w6@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=vinmenon@codeaurora.org \
--cc=vjitta@codeaurora.org \
--cc=ylal@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.