All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhou Wang <wangzhou1@hisilicon.com>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-accelerators@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Sihang Chen <chensihang1@hisilicon.com>
Subject: Re: [PATCH] uacce: Add uacce_ctrl misc device
Date: Fri, 22 Jan 2021 12:38:51 +0100	[thread overview]
Message-ID: <YAq5S2RAQV25+iaG@kroah.com> (raw)
In-Reply-To: <dcbe9a53-8aa0-10f5-4e78-ae0ab94171de@hisilicon.com>

On Fri, Jan 22, 2021 at 07:33:40PM +0800, Zhou Wang wrote:
> >> +struct uacce_pin_address {
> >> +	unsigned long addr;
> >> +	unsigned long size;
> > 
> > These are not valid ioctl structure members for crossing the user/kernel
> > boundry.  Please make them work properly (i.e. use __u64 and friends).
> 
> Got it, will modify this to __u64 together with other problems found by 0-day robot.

Please also properly involve the mm and dma developers and, again,
consider just making this a syscall instead of an ioctl.

thanks,

greg k-h

  reply	other threads:[~2021-01-22 11:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  9:09 [PATCH] uacce: Add uacce_ctrl misc device Zhou Wang
2021-01-21  9:44 ` Greg Kroah-Hartman
2021-01-22 11:33   ` Zhou Wang
2021-01-22 11:38     ` Greg Kroah-Hartman [this message]
2021-01-21  9:45 ` Greg Kroah-Hartman
2021-01-21 10:18   ` Song Bao Hua (Barry Song)
2021-01-21 11:18     ` Greg Kroah-Hartman
2021-01-21 11:52       ` Song Bao Hua (Barry Song)
2021-01-21 12:12         ` Greg Kroah-Hartman
2021-01-21 10:44 ` kernel test robot
2021-01-21 10:44   ` kernel test robot
2021-01-21 11:43 ` kernel test robot
2021-01-21 11:43   ` kernel test robot
2021-01-21 11:43 ` [RFC PATCH] uacce: uacce_ctrl_open() can be static kernel test robot
2021-01-21 11:43   ` kernel test robot
2021-01-21 13:27 ` [PATCH] uacce: Add uacce_ctrl misc device kernel test robot
2021-01-21 13:27   ` kernel test robot
2021-01-21 17:16 ` kernel test robot
2021-01-21 17:16   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAq5S2RAQV25+iaG@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=chensihang1@hisilicon.com \
    --cc=linux-accelerators@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.