From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3 3/6] lib/cmdline: Allow get_options() to take 0 to validate the input
Date: Fri, 22 Jan 2021 15:49:10 +0200 [thread overview]
Message-ID: <YArX1qdDk5DYaLck@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVekbD0tYsQEVXc6W1OnETziVoFpU9WMgZw5C5ufc+72A@mail.gmail.com>
On Fri, Jan 22, 2021 at 02:13:10PM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 22, 2021 at 1:39 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > + while (i < nints || validate) {
> > + int *pint = validate ? ints : ints + i;
>
> I think you can use NULL for validation, as per the documentation for
> get_option().
That's what takes me a long time to realize how this machinery works and no,
unfortunately we may not use NULL, we have to keep the parsed number
for the further operations.
Thanks for review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-22 13:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 12:38 [PATCH v3 1/6] lib/cmdline_kunit: add a new test case for get_options() Andy Shevchenko
2021-01-22 12:38 ` [PATCH v3 2/6] lib/cmdline: Update documentation to reflect behaviour Andy Shevchenko
2021-01-22 13:10 ` Geert Uytterhoeven
2021-01-22 13:47 ` Andy Shevchenko
2021-01-22 12:38 ` [PATCH v3 3/6] lib/cmdline: Allow get_options() to take 0 to validate the input Andy Shevchenko
2021-01-22 13:13 ` Geert Uytterhoeven
2021-01-22 13:49 ` Andy Shevchenko [this message]
2021-01-22 12:38 ` [PATCH v3 4/6] gpio: aggregator: Replace isrange() by using get_options() Andy Shevchenko
2021-01-22 13:14 ` Geert Uytterhoeven
2021-01-22 12:38 ` [PATCH v3 5/6] gpio: aggregator: Use compound literal from the header Andy Shevchenko
2021-01-22 13:22 ` Geert Uytterhoeven
2021-01-22 12:38 ` [PATCH v3 6/6] gpio: aggregator: Remove trailing comma in terminator entries Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YArX1qdDk5DYaLck@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.