From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 454F5C433E0 for ; Sun, 7 Feb 2021 09:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C26564E43 for ; Sun, 7 Feb 2021 09:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbhBGJSt (ORCPT ); Sun, 7 Feb 2021 04:18:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:35300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbhBGJSr (ORCPT ); Sun, 7 Feb 2021 04:18:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9361B64E22; Sun, 7 Feb 2021 09:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612689486; bh=M+7Vjj0l8SWkkCAfHsTiuFeZisfU3zkOxBiol6f8cvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JzWhpLNn2V57naiWxS4uA4F/40eR6CV/py3pinOi1yXfpWjytSpfXty7e+qvs6oqC 4nUaKQtfIPxH/RHs8A0JHDTn8dR5ov8SAQlbXeJamysGtCeQuZ42D/o07NcGc7rDX9 M9joDAf8O1qqPXUmc4rRwFcdSiqZ0dL6mBS8J/lI= Date: Sun, 7 Feb 2021 10:18:01 +0100 From: Greg KH To: Kumar Kartikeya Dwivedi Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Stephen Rothwell Subject: Re: [PATCH v3] staging: emxx_udc: Make incorrectly defined global static Message-ID: References: <20210207085911.270746-1-memxor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210207085911.270746-1-memxor@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 07, 2021 at 02:29:12PM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int vbus_irq were defined in the header, > instead put the definitions in the translation unit and make them static as > there's only a single consumer, and these symbols shouldn't pollute the > global namespace. > > This fixes the following sparse warnings for this driver: > drivers/staging/emxx_udc/emxx_udc.c: note: in included file: > drivers/staging/emxx_udc/emxx_udc.h:23:18: warning: symbol 'vbus_gpio' was not > declared. Should it be static? drivers/staging/emxx_udc/emxx_udc.h:24:5: > warning: symbol 'vbus_irq' was not declared. Should it be static? > > Signed-off-by: Kumar Kartikeya Dwivedi > --- > Changes in v1: > Switch to variable with static linkage instead of extern > Changes in v2: > Resend a versioned patch > Changes in v3: > Include version changelog below the marker Much better, thanks, now queued up. greg k-h