From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/4] Prevent linker issues in lapi/io_uring.h
Date: Fri, 5 Feb 2021 17:09:54 +0100 [thread overview]
Message-ID: <YB1t0lP2j+x2yKdn@pevik> (raw)
In-Reply-To: <20210204110342.11821-1-mdoucha@suse.cz>
Hi Martin,
> Fallback io_uring syscall wrappers were not defined as static inline. This
> will lead to linker issues when safe function variants get added to LTP
> library.
> Also add check for <linux/io_uring.h> to configure script and #include it
> in the LAPI header if it's available.
Thanks for cleanup!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> +++ b/configure.ac
> @@ -49,6 +49,7 @@ AC_CHECK_HEADERS_ONCE([ \
> linux/if_alg.h \
> linux/if_ether.h \
> linux/if_packet.h \
> + linux/io_uring.h \
> linux/keyctl.h \
> linux/mempolicy.h \
> linux/module.h \
...
> +++ b/include/lapi/io_uring.h
...
> +#ifdef HAVE_LINUX_IO_URING_H
> +#include <linux/io_uring.h>
> +#endif
> +
> #ifndef IOSQE_FIXED_FILE
This could be also guarded as ! HAVE_LINUX_IO_URING_H (#else branch), but
keeping IOSQE_FIXED_FILE is probably safer.
> #ifndef __kernel_rwf_t
> @@ -260,8 +264,8 @@ struct io_uring_probe {
> #ifndef HAVE_IO_URING_REGISTER
> -int io_uring_register(int fd, unsigned int opcode, void *arg,
> - unsigned int nr_args)
> +static inline int io_uring_register(int fd, unsigned int opcode, void *arg,
> + unsigned int nr_args)
> {
> return tst_syscall(__NR_io_uring_register, fd, opcode, arg, nr_args);
> }
> @@ -269,22 +273,23 @@ int io_uring_register(int fd, unsigned int opcode, void *arg,
...
Kind regards,
Petr
prev parent reply other threads:[~2021-02-05 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 11:03 [LTP] [PATCH v2 1/4] Prevent linker issues in lapi/io_uring.h Martin Doucha
2021-02-04 11:03 ` [LTP] [PATCH v2 2/4] Add safe functions for io_uring to LTP library Martin Doucha
2021-02-05 15:56 ` Petr Vorel
2021-02-05 16:03 ` Martin Doucha
2021-02-05 17:06 ` Petr Vorel
2021-02-04 11:03 ` [LTP] [PATCH v2 3/4] Add CAP_SYS_CHROOT to lapi/capability.h Martin Doucha
2021-02-04 11:03 ` [LTP] [PATCH v2 4/4] Add test for CVE 2020-29373 Martin Doucha
2021-02-05 16:49 ` Petr Vorel
2021-02-08 9:37 ` Martin Doucha
2021-02-08 9:48 ` Petr Vorel
2021-02-05 16:09 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YB1t0lP2j+x2yKdn@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.