From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, stable@vger.kernel.org,
lwn@lwn.net, jslaby@suse.cz, shuah@kernel.org,
patches@kernelci.org, lkft-triage@lists.linaro.org,
pavel@denx.de, jonathanh@nvidia.com
Subject: Re: Linux 4.4.256
Date: Sat, 6 Feb 2021 14:19:57 +0100 [thread overview]
Message-ID: <YB6XfR5YDz8IjZHu@kroah.com> (raw)
In-Reply-To: <20210206131113.GB7312@1wt.eu>
On Sat, Feb 06, 2021 at 02:11:13PM +0100, Willy Tarreau wrote:
> On Sat, Feb 06, 2021 at 02:00:27PM +0100, Greg Kroah-Hartman wrote:
> > I think Sasha's patch here:
> > https://lore.kernel.org/r/20210205174702.1904681-1-sashal@kernel.org
> > is looking like the solution.
>
> It might cause trouble to those forcing SUBLEVEL to a given version such
> as .0 to avoid exposing the exact stable version. I guess we should
> instead try to integrate a test on the value itself and cap it at 255.
That's the main goal of the upstream submission that checks the value
before capping it:
https://lore.kernel.org/r/20210206035033.2036180-2-sashal@kernel.org
> Something like this looks more robust to me, it will use SUBLEVEL for
> values 0 to 255 and 255 for any larger value:
>
> - expr $(VERSION) \* 65536 + 0$(PATCHLEVEL) \* 256 + 0$(SUBLEVEL)); \
> + expr $(VERSION) \* 65536 + 0$(PATCHLEVEL) \* 256 + 255 \* (0$(SUBLEVEL) > 255) + 0$(SUBLEVEL) * (0$(SUBLEVEL \<= 255)); \
I think you just rewrote the above linked patch :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-06 13:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 14:26 Linux 4.4.256 Greg Kroah-Hartman
2021-02-05 14:26 ` Greg Kroah-Hartman
2021-02-05 20:56 ` Guenter Roeck
2021-02-06 13:00 ` Greg Kroah-Hartman
2021-02-06 13:11 ` Willy Tarreau
2021-02-06 13:19 ` Greg Kroah-Hartman [this message]
2021-02-06 13:24 ` Willy Tarreau
2021-02-06 13:22 ` Willy Tarreau
2021-02-06 16:59 ` Guenter Roeck
2021-02-06 18:13 ` Greg Kroah-Hartman
2021-02-06 18:49 ` Guenter Roeck
2021-02-07 8:22 ` Greg Kroah-Hartman
2021-02-08 17:14 ` Guenter Roeck
2021-02-08 17:20 ` Greg Kroah-Hartman
2021-02-08 9:09 ` David Laight
2021-02-08 9:38 ` David Laight
2021-02-08 9:44 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YB6XfR5YDz8IjZHu@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=lwn@lwn.net \
--cc=patches@kernelci.org \
--cc=pavel@denx.de \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.