From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F08C433E0 for ; Tue, 26 Jan 2021 15:24:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2440522D58 for ; Tue, 26 Jan 2021 15:24:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2440522D58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XUzorgjnpYzUnSmJ0JigQ3Ub82BeJX6pQHKtiQnSWgA=; b=nygQ8EQMWx2Lijs9LU+weRweA 0Os/SjSkTvPekM7r6aSkjbZz9X/MzrUofb/Eht2IaM3agejj2JmSLqYWsGV5eUzCjeToJxf9uTIxZ FNDM5m48+iD7NkMn+jl4XAosZYRNIwABMyU8luJWkaB8+LvqMsxiwVm0G1n7HAbc3HvlKn13vUeyc r78PdvvZMLoEgNoopnJ1m/MDXikl7eVkor9eUSip/r85zotB1Tm2+qiXSwAFgOUNxmx1KTAhTZ+bc wrO29lBoMVZnGxbnanWSwmV7LY4pKj5z2tlMC3iFY0UK3gaC+4sfVbQjP+pXD1Ti8LbZABWWr0w9j bphXCMCKw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4QCz-0002RS-6Z; Tue, 26 Jan 2021 15:24:45 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4OL4-0007om-A2; Tue, 26 Jan 2021 13:24:59 +0000 IronPort-SDR: XaU55DbI5Qo+hlSSIRltyDZkcArTX9POvwvs0bOX/cq/ChDOqLhm4R+evFI10/X9aiAHDTIgM2 dq92SLkxzfsA== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="198687066" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="198687066" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:24:54 -0800 IronPort-SDR: g4Zswe3qz4zMid/EyEG5xz4WWhFPriWd/t2t5KrG0ShP0j9WNEEJayXNCJQTEkRkM2/IHRNzgx zk+bb8SSGplQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="369103591" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 26 Jan 2021 05:24:36 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Jan 2021 15:24:35 +0200 Date: Tue, 26 Jan 2021 15:24:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-10-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163537.1466118-10-maxime@cerno.tech> X-Patchwork-Hint: comment X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210126_082458_491685_9F77754B X-CRM114-Status: GOOD ( 17.07 ) X-Mailman-Approved-At: Tue, 26 Jan 2021 10:24:44 -0500 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Alexandre Belloni , Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Russell King , Paul Cercueil , Thierry Reding , Gerd Hoffmann , Anitha Chrisanthus , Daniel Vetter , Sam Ravnborg , Jerome Brunet , Marek Vasut , linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , linux-rockchip@lists.infradead.org, Alexey Brodkin , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Roland Scheidegger , Xinliang Liu , Chen-Yu Tsai , VMware Graphics , NXP Linux Team , Chen Feng , Dave Airlie , Xinwei Kong , Chun-Kuang Hu , Alexandre Torgue , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sascha Hauer , Alison Wang , Maarten Lankhorst , linux-mips@vger.kernel.org, Hans de Goede , linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mediatek@lists.infradead, Hyun Kwon , Philippe Cornu , Sandy Huang , Yannick Fertre , Ludovic Desroches , Thomas Zimmermann , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 05:35:35PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic state since > _swap_state happened when those hooks are run. > = > Use the drm_atomic_get_new_plane_state helper to get that state to make it > more obvious. > = > This was made using the coccinelle script below: > = > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > = > ( > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_disable =3D func, > ..., > }; > | > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_update =3D func, > ..., > }; > ) > = > @ adds_new_state @ > identifier plane_atomic_func.func; > identifier plane, state; > identifier new_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) > { > ... > - struct drm_plane_state *new_state =3D plane->state; > + struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, plane); > ... > } > = > @ include depends on adds_new_state @ > @@ > = > #include > = > @ no_include depends on !include && adds_new_state @ > @@ > = > + #include > #include > = > Signed-off-by: Maxime Ripard Looks great. Reviewed-by: Ville Syrj=E4l=E4 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F39C7C433DB for ; Tue, 26 Jan 2021 13:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8F04230FC for ; Tue, 26 Jan 2021 13:38:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404437AbhAZNfx (ORCPT ); Tue, 26 Jan 2021 08:35:53 -0500 Received: from mga06.intel.com ([134.134.136.31]:48273 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392005AbhAZN0n (ORCPT ); Tue, 26 Jan 2021 08:26:43 -0500 IronPort-SDR: Ksr2gGZ7dn03b/85c1HgNMlPduJ5NJC4EiCDNMkUNQVcrdHtToYzTjEMhgvdUx+T9+FNarGHaf N+TpHz0X3cag== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="241429103" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="241429103" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:24:53 -0800 IronPort-SDR: g4Zswe3qz4zMid/EyEG5xz4WWhFPriWd/t2t5KrG0ShP0j9WNEEJayXNCJQTEkRkM2/IHRNzgx zk+bb8SSGplQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="369103591" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 26 Jan 2021 05:24:36 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Jan 2021 15:24:35 +0200 Date: Tue, 26 Jan 2021 15:24:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Haneen Mohammed , Alexandre Belloni , Neil Armstrong , Xinliang Liu , Liviu Dudau , dri-devel@lists.freedesktop.org, Sandy Huang , Paul Cercueil , linux-tegra@vger.kernel.org, Chen-Yu Tsai , Thierry Reding , Gerd Hoffmann , Anitha Chrisanthus , Sam Ravnborg , Michal Simek , Jerome Brunet , Marek Vasut , Yannick Fertre , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , linux-rockchip@lists.infradead.org, Alexey Brodkin , Russell King , Krzysztof Kozlowski , Jonathan Hunter , freedreno@lists.freedesktop.org, Ludovic Desroches , VMware Graphics , NXP Linux Team , linux-arm-msm@vger.kernel.org, Philippe Cornu , Dave Airlie , Xinwei Kong , virtualization@lists.linux-foundation.org, Hyun Kwon , Chun-Kuang Hu , Alexandre Torgue , Martin Blumenstingl , Chen Feng , Sascha Hauer , Alison Wang , Roland Scheidegger , linux-renesas-soc@vger.kernel.org, linux-mips@vger.kernel.org, Hans de Goede , linux-mediatek@lists.infradead Subject: Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-10-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210121163537.1466118-10-maxime@cerno.tech> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Jan 21, 2021 at 05:35:35PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic state since > _swap_state happened when those hooks are run. > > Use the drm_atomic_get_new_plane_state helper to get that state to make it > more obvious. > > This was made using the coccinelle script below: > > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > > ( > static const struct drm_plane_helper_funcs helpers = { > ..., > .atomic_disable = func, > ..., > }; > | > static const struct drm_plane_helper_funcs helpers = { > ..., > .atomic_update = func, > ..., > }; > ) > > @ adds_new_state @ > identifier plane_atomic_func.func; > identifier plane, state; > identifier new_state; > @@ > > func(struct drm_plane *plane, struct drm_atomic_state *state) > { > ... > - struct drm_plane_state *new_state = plane->state; > + struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane); > ... > } > > @ include depends on adds_new_state @ > @@ > > #include > > @ no_include depends on !include && adds_new_state @ > @@ > > + #include > #include > > Signed-off-by: Maxime Ripard Looks great. Reviewed-by: Ville Syrjälä -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09583C433DB for ; Tue, 26 Jan 2021 13:25:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAE96207A0 for ; Tue, 26 Jan 2021 13:25:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAE96207A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DZU1qukygw88lJ8y8+bNjIg6omQ35wLZVgWWd6kH2os=; b=fK/T0yMylMg0buDes27rpt3NX 9a1XGVNTUNxu1R3AWpWsIx2sd8694GWhhQC14g/tMifjja6Za+ri6tDDKhaUzTuksbG6k0/6z/PI6 1VWrrlPpiCnK4IAc7ZiqCAQaRwBSxi+xKU6TQ1YM+IMIr5a50swCEs6CYCbCvbt+be4JMR1y6PSqq gYySdQYnhB8hBMghekpYxon2oheeabzyjZ80Jh7+IAh+gVr8GG9WtbudjUtIkepNQokLStr1r6dbJ /rbCkO69Rk1qbZT9NZRg4mHG9LOkToIJNWNo05jKqktx6eeUtOUpDICxZECJDouwFjFUm+gnn0n5s 7JR8+WkTw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4OL6-0007pf-8B; Tue, 26 Jan 2021 13:25:00 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4OL4-0007om-A2; Tue, 26 Jan 2021 13:24:59 +0000 IronPort-SDR: XaU55DbI5Qo+hlSSIRltyDZkcArTX9POvwvs0bOX/cq/ChDOqLhm4R+evFI10/X9aiAHDTIgM2 dq92SLkxzfsA== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="198687066" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="198687066" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:24:54 -0800 IronPort-SDR: g4Zswe3qz4zMid/EyEG5xz4WWhFPriWd/t2t5KrG0ShP0j9WNEEJayXNCJQTEkRkM2/IHRNzgx zk+bb8SSGplQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="369103591" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 26 Jan 2021 05:24:36 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Jan 2021 15:24:35 +0200 Date: Tue, 26 Jan 2021 15:24:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-10-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163537.1466118-10-maxime@cerno.tech> X-Patchwork-Hint: comment X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210126_082458_491685_9F77754B X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Alexandre Belloni , Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Russell King , Paul Cercueil , Thierry Reding , Gerd Hoffmann , Anitha Chrisanthus , Daniel Vetter , Sam Ravnborg , Jerome Brunet , Marek Vasut , linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , linux-rockchip@lists.infradead.org, Alexey Brodkin , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Roland Scheidegger , Xinliang Liu , Chen-Yu Tsai , VMware Graphics , NXP Linux Team , Chen Feng , Dave Airlie , Xinwei Kong , Chun-Kuang Hu , Alexandre Torgue , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sascha Hauer , Alison Wang , Maarten Lankhorst , linux-mips@vger.kernel.org, Hans de Goede , linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mediatek@lists.infradead, Hyun Kwon , Philippe Cornu , Sandy Huang , Yannick Fertre , Ludovic Desroches , Thomas Zimmermann , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 05:35:35PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic state since > _swap_state happened when those hooks are run. > = > Use the drm_atomic_get_new_plane_state helper to get that state to make it > more obvious. > = > This was made using the coccinelle script below: > = > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > = > ( > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_disable =3D func, > ..., > }; > | > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_update =3D func, > ..., > }; > ) > = > @ adds_new_state @ > identifier plane_atomic_func.func; > identifier plane, state; > identifier new_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) > { > ... > - struct drm_plane_state *new_state =3D plane->state; > + struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, plane); > ... > } > = > @ include depends on adds_new_state @ > @@ > = > #include > = > @ no_include depends on !include && adds_new_state @ > @@ > = > + #include > #include > = > Signed-off-by: Maxime Ripard Looks great. Reviewed-by: Ville Syrj=E4l=E4 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B47D0C433DB for ; Tue, 26 Jan 2021 13:25:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B9B9206F9 for ; Tue, 26 Jan 2021 13:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B9B9206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KUC8dTL7QMHZ+bBxkwXeRjdVeg9ZuLL4jG3e8PhLnyI=; b=gke+jy+4XgCfGDoyyXlp6IkDP dnlTi1tjoV4DY+GVNDeErVsVZGIzIRhI4KK+2u16Hj90Z63S6NpfOIvk9yMka7kYE+4WdSBFuVLPm gL/GRd/rtHZlo8V0by8TGMoyMQj7s0oUPOesy/juuc+8i57Q3acPyE1qZzKX6COObY/yb6NpN7Fq3 qh2UTLPRuJjd5ZHyrbam1PdVXNEqSSvVT7IhrY5MTKiRMsxU6SuLV9ocYk9GgtS2d+z/P0p7B7jxh 9qYCNVK+MJ+6Y8fnR13EDKn/oghEPVyMCZQSQoIZV8wgSjWYzhBHbAfhT6RViv41wDeaQHa+NSgWM aetGBESBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4OL8-0007qz-OD; Tue, 26 Jan 2021 13:25:03 +0000 Received: from mga01.intel.com ([192.55.52.88]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4OL4-0007om-A2; Tue, 26 Jan 2021 13:24:59 +0000 IronPort-SDR: XaU55DbI5Qo+hlSSIRltyDZkcArTX9POvwvs0bOX/cq/ChDOqLhm4R+evFI10/X9aiAHDTIgM2 dq92SLkxzfsA== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="198687066" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="198687066" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:24:54 -0800 IronPort-SDR: g4Zswe3qz4zMid/EyEG5xz4WWhFPriWd/t2t5KrG0ShP0j9WNEEJayXNCJQTEkRkM2/IHRNzgx zk+bb8SSGplQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="369103591" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 26 Jan 2021 05:24:36 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Jan 2021 15:24:35 +0200 Date: Tue, 26 Jan 2021 15:24:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-10-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163537.1466118-10-maxime@cerno.tech> X-Patchwork-Hint: comment X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210126_082458_491685_9F77754B X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Alexandre Belloni , Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Russell King , Paul Cercueil , Thierry Reding , Gerd Hoffmann , Anitha Chrisanthus , Daniel Vetter , Sam Ravnborg , Jerome Brunet , Marek Vasut , linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , linux-rockchip@lists.infradead.org, Alexey Brodkin , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Roland Scheidegger , Xinliang Liu , Chen-Yu Tsai , VMware Graphics , NXP Linux Team , Chen Feng , Dave Airlie , Xinwei Kong , Chun-Kuang Hu , Alexandre Torgue , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sascha Hauer , Alison Wang , Maarten Lankhorst , linux-mips@vger.kernel.org, Hans de Goede , linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mediatek@lists.infradead, Hyun Kwon , Philippe Cornu , Sandy Huang , Yannick Fertre , Ludovic Desroches , Thomas Zimmermann , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 05:35:35PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic state since > _swap_state happened when those hooks are run. > = > Use the drm_atomic_get_new_plane_state helper to get that state to make it > more obvious. > = > This was made using the coccinelle script below: > = > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > = > ( > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_disable =3D func, > ..., > }; > | > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_update =3D func, > ..., > }; > ) > = > @ adds_new_state @ > identifier plane_atomic_func.func; > identifier plane, state; > identifier new_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) > { > ... > - struct drm_plane_state *new_state =3D plane->state; > + struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, plane); > ... > } > = > @ include depends on adds_new_state @ > @@ > = > #include > = > @ no_include depends on !include && adds_new_state @ > @@ > = > + #include > #include > = > Signed-off-by: Maxime Ripard Looks great. Reviewed-by: Ville Syrj=E4l=E4 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A49C433E0 for ; Tue, 26 Jan 2021 13:25:01 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DDF9207A0 for ; Tue, 26 Jan 2021 13:25:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DDF9207A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4F8C385570; Tue, 26 Jan 2021 13:25:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MowYLPLQ4-DT; Tue, 26 Jan 2021 13:24:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0313185585; Tue, 26 Jan 2021 13:24:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D7BCFC08A1; Tue, 26 Jan 2021 13:24:57 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 509ACC013A for ; Tue, 26 Jan 2021 13:24:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4702220017 for ; Tue, 26 Jan 2021 13:24:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OBOy7of-EatA for ; Tue, 26 Jan 2021 13:24:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by silver.osuosl.org (Postfix) with ESMTPS id 38AB6203FE for ; Tue, 26 Jan 2021 13:24:55 +0000 (UTC) IronPort-SDR: Czce/Y4eMov5sa74LU5Z+7KwWnWWL8YOzLa66xoUmTA809pKzJFTpjBOeujRU/kn7n94ZtBNFh BLyhDvnQX8sw== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="241429101" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="241429101" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:24:53 -0800 IronPort-SDR: g4Zswe3qz4zMid/EyEG5xz4WWhFPriWd/t2t5KrG0ShP0j9WNEEJayXNCJQTEkRkM2/IHRNzgx zk+bb8SSGplQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="369103591" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 26 Jan 2021 05:24:36 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Jan 2021 15:24:35 +0200 Date: Tue, 26 Jan 2021 15:24:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-10-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163537.1466118-10-maxime@cerno.tech> X-Patchwork-Hint: comment Cc: Haneen Mohammed , Alexandre Belloni , Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Russell King , Paul Cercueil , Thierry Reding , Anitha Chrisanthus , Daniel Vetter , Sam Ravnborg , Jerome Brunet , Marek Vasut , linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , linux-rockchip@lists.infradead.org, Alexey Brodkin , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Roland Scheidegger , Xinliang Liu , Chen-Yu Tsai , VMware Graphics , NXP Linux Team , Chen Feng , Dave Airlie , Xinwei Kong , Chun-Kuang Hu , Alexandre Torgue , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sascha Hauer , Alison Wang , Maarten Lankhorst , linux-mips@vger.kernel.org, Hans de Goede , linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mediatek@lists.infradead, Hyun Kwon , Philippe Cornu , Sandy Huang , Yannick Fertre , Ludovic Desroches , Thomas Zimmermann , freedreno@lists.freedesktop.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Jan 21, 2021 at 05:35:35PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic state since > _swap_state happened when those hooks are run. > = > Use the drm_atomic_get_new_plane_state helper to get that state to make it > more obvious. > = > This was made using the coccinelle script below: > = > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > = > ( > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_disable =3D func, > ..., > }; > | > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_update =3D func, > ..., > }; > ) > = > @ adds_new_state @ > identifier plane_atomic_func.func; > identifier plane, state; > identifier new_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) > { > ... > - struct drm_plane_state *new_state =3D plane->state; > + struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, plane); > ... > } > = > @ include depends on adds_new_state @ > @@ > = > #include > = > @ no_include depends on !include && adds_new_state @ > @@ > = > + #include > #include > = > Signed-off-by: Maxime Ripard Looks great. Reviewed-by: Ville Syrj=E4l=E4 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F47FC433E0 for ; Tue, 26 Jan 2021 13:24:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF05B207A0 for ; Tue, 26 Jan 2021 13:24:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF05B207A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FE576E441; Tue, 26 Jan 2021 13:24:57 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1FA46E42C; Tue, 26 Jan 2021 13:24:55 +0000 (UTC) IronPort-SDR: 3jggMRwRq58De0zrwRXO2+p1J/gxR3HUv8ddGx7J9uK/TaapUeUqTkTVwMLHlfrvzn21orOzYi dSSXMw8PRgHw== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="243979561" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="243979561" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:24:53 -0800 IronPort-SDR: g4Zswe3qz4zMid/EyEG5xz4WWhFPriWd/t2t5KrG0ShP0j9WNEEJayXNCJQTEkRkM2/IHRNzgx zk+bb8SSGplQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="369103591" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 26 Jan 2021 05:24:36 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 26 Jan 2021 15:24:35 +0200 Date: Tue, 26 Jan 2021 15:24:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer Message-ID: References: <20210121163537.1466118-1-maxime@cerno.tech> <20210121163537.1466118-10-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210121163537.1466118-10-maxime@cerno.tech> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Alexandre Belloni , Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Russell King , Paul Cercueil , Thierry Reding , Gerd Hoffmann , Anitha Chrisanthus , Daniel Vetter , Sam Ravnborg , Jerome Brunet , Marek Vasut , linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , linux-rockchip@lists.infradead.org, Alexey Brodkin , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Roland Scheidegger , Xinliang Liu , Chen-Yu Tsai , VMware Graphics , NXP Linux Team , Chen Feng , Dave Airlie , Xinwei Kong , Chun-Kuang Hu , Alexandre Torgue , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sascha Hauer , Alison Wang , linux-mips@vger.kernel.org, Hans de Goede , linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mediatek@lists.infradead, Hyun Kwon , Philippe Cornu , Sandy Huang , Yannick Fertre , Ludovic Desroches , Thomas Zimmermann , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 21, 2021 at 05:35:35PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic state since > _swap_state happened when those hooks are run. > = > Use the drm_atomic_get_new_plane_state helper to get that state to make it > more obvious. > = > This was made using the coccinelle script below: > = > @ plane_atomic_func @ > identifier helpers; > identifier func; > @@ > = > ( > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_disable =3D func, > ..., > }; > | > static const struct drm_plane_helper_funcs helpers =3D { > ..., > .atomic_update =3D func, > ..., > }; > ) > = > @ adds_new_state @ > identifier plane_atomic_func.func; > identifier plane, state; > identifier new_state; > @@ > = > func(struct drm_plane *plane, struct drm_atomic_state *state) > { > ... > - struct drm_plane_state *new_state =3D plane->state; > + struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(st= ate, plane); > ... > } > = > @ include depends on adds_new_state @ > @@ > = > #include > = > @ no_include depends on !include && adds_new_state @ > @@ > = > + #include > #include > = > Signed-off-by: Maxime Ripard Looks great. Reviewed-by: Ville Syrj=E4l=E4 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel