From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Date: Tue, 26 Jan 2021 14:31:26 +0000 Subject: Re: [PATCH] USB: serial: mos7840: fix error code in mos7840_write() Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Johan Hovold , Greg Kroah-Hartman , Paul B Schroeder , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Jan 26, 2021 at 01:26:54PM +0300, Dan Carpenter wrote: > This should return -ENOMEM instead of 0 if the kmalloc() fails. > > Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver") > Signed-off-by: Dan Carpenter Applied, thanks. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE76EC433DB for ; Tue, 26 Jan 2021 14:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F127230FC for ; Tue, 26 Jan 2021 14:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392742AbhAZOeC (ORCPT ); Tue, 26 Jan 2021 09:34:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:55858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392764AbhAZOb6 (ORCPT ); Tue, 26 Jan 2021 09:31:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4E7D522EBD; Tue, 26 Jan 2021 14:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611671478; bh=lCDeEllePGSdbC047wovpja/TxDcxspb898XpipaVc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HRFJzuy3C6mTXV1Gcu/3015BtWNKEwMMNA+dO6P6cvWTPsTaV2MEKe1nko/O42ZRs mQUGWHoclmR/bcTV59HtIORnG4rAzgg80RXLjcVYHydFYS5TDPeKAcYivi8QUj8CQ4 cBR4mcLE+AbphShfCXBAzC4K2OafWJQbCYsmPmCfmjqnNZi80k5ttd6GDvoHZpceZj /GZB9WinGx3JiPnQtWoPTI4SBfRRrwvYzpytvYAdvrXU5w7bXKEax/k8P0es7D6Gms zRvHeHcumXT1YcjWLLXJzkfBXh0+36IBMU1fe/WU5Lk9i3UHDpm85D28DAqXqI+LD7 mnd5sIl/qddTQ== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1l4PNO-0007dd-VZ; Tue, 26 Jan 2021 15:31:27 +0100 Date: Tue, 26 Jan 2021 15:31:26 +0100 From: Johan Hovold To: Dan Carpenter Cc: Johan Hovold , Greg Kroah-Hartman , Paul B Schroeder , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] USB: serial: mos7840: fix error code in mos7840_write() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Jan 26, 2021 at 01:26:54PM +0300, Dan Carpenter wrote: > This should return -ENOMEM instead of 0 if the kmalloc() fails. > > Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver") > Signed-off-by: Dan Carpenter Applied, thanks. Johan