From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] clk: tegra: clk-dfll: Verify regulator vsel values are valid
Date: Wed, 27 Jan 2021 19:25:52 +0100 [thread overview]
Message-ID: <YBGwMBxNeSlaPjuB@ulmo> (raw)
In-Reply-To: <20210127171121.322765-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On Wed, Jan 27, 2021 at 05:11:21PM +0000, Jon Hunter wrote:
> The regulator function, regulator_list_hardware_vsel(), may return an
> negative error code on failure. The Tegra DFLL driver does not check to
> see if the value returned by this function is an error. Fix this by
> updating the DFLL driver to check if the value returned by
> regulator_list_hardware_vsel() is an error and if an error does occur
> propagate the error.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/clk/tegra/clk-dfll.c | 32 ++++++++++++++++++++++++--------
> 1 file changed, 24 insertions(+), 8 deletions(-)
Does this fix any particular issue? Do we want a Fixes: line for this?
In either case, this looks like a correct fix, so:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-27 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 17:11 [PATCH] clk: tegra: clk-dfll: Verify regulator vsel values are valid Jon Hunter
2021-01-27 18:25 ` Thierry Reding [this message]
2021-01-28 11:24 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBGwMBxNeSlaPjuB@ulmo \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.