Re: [char-misc:char-misc-testing 33/62] drivers/misc/bcm-vk/bcm_vk_msg.c:56:35: warning: operator has lower precedence than '|'; '|' will be evaluated first

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

On Thu, Jan 28, 2021 at 01:42:55PM +0800, kernel test robot wrote:
> vim +56 drivers/misc/bcm-vk/bcm_vk_msg.c
> 
>     52	
>     53	static void set_q_num(struct vk_msg_blk *msg, u32 q_num)
>     54	{
>     55		msg->trans_id = (msg->trans_id & ~BCM_VK_MSG_Q_MASK) |
>   > 56			(q_num >= VK_MSGQ_PER_CHAN_MAX) ? VK_MSGQ_NUM_DEFAULT : q_num;

That is a pretty horrible chunk of code, Scott, can you make this a
"real" if statement please so that we can read it?  :)

thanks,

greg k-h