From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Fri, 29 Jan 2021 14:21:48 +0100 Subject: [LTP] [PATCH v2 1/2] syscalls/sched_getparam{01, 02}: Convert to new API and cleanup In-Reply-To: <20210126022631.2566169-1-yangx.jy@cn.fujitsu.com> References: <20201214063729.1656200-1-yangx.jy@cn.fujitsu.com> <20210126022631.2566169-1-yangx.jy@cn.fujitsu.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > + if (param.sched_priority) { > + tst_res(TFAIL, > + "sched_getparam(%d) got wrong sched_priority %d, expected 0", > + pids[n], param.sched_priority); > + exit(1); I do not think that we should do exit(1) here, since that would cause TBROK in the library when we reap the children. The failure is propagated by the tst_res(TFAIL, ...) here already. With the exit(1) replaced by exit(0): Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz