From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/5] zram01.sh: Check properly mkfs.* dependencies
Date: Fri, 29 Jan 2021 19:34:09 +0100 [thread overview]
Message-ID: <YBRVIRfgCPD+GA4b@yuki.lan> (raw)
In-Reply-To: <YBRM7w0dNypJm2tD@pevik>
Hi!
> > Also I'm confused how this is supposed to work, we do limit the dev_num
> > but the zram_filesystems is untouched? That isn't going to work right.
> It actually works due this check in functions it uses:
> [ $i -eq $dev_num ] && break
> (maybe more readable to use -ge ).
So if we have ext3 unsupported we will loop over ext3, ext4 and xfs
there and break just before btrfs?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-01-29 18:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 12:18 [LTP] [PATCH 0/5] zram cleanup Petr Vorel
2021-01-29 12:18 ` [LTP] [PATCH 1/5] zram: Require root Petr Vorel
2021-01-29 14:09 ` Cyril Hrubis
2021-01-29 15:40 ` Petr Vorel
2021-01-29 12:18 ` [LTP] [PATCH 2/5] zram: Calculate dev_num variable Petr Vorel
2021-01-29 14:17 ` Cyril Hrubis
2021-01-29 12:18 ` [LTP] [PATCH 3/5] zram01.sh: Check properly mkfs.* dependencies Petr Vorel
2021-01-29 16:11 ` Cyril Hrubis
2021-01-29 17:59 ` Petr Vorel
2021-01-29 18:34 ` Cyril Hrubis [this message]
2021-01-29 19:21 ` Petr Vorel
2021-01-29 12:18 ` [LTP] [PATCH 4/5] zram: Move zram_compress_alg() to zram02.sh Petr Vorel
2021-01-29 12:18 ` [LTP] [PATCH 5/5] zram: Move test specific functions out of zram_lib.sh Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBRVIRfgCPD+GA4b@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.