From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68CAC433E0 for ; Mon, 1 Feb 2021 19:38:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7141F64DBA for ; Mon, 1 Feb 2021 19:38:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7141F64DBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 158FB6E200; Mon, 1 Feb 2021 19:38:44 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC56C6E200 for ; Mon, 1 Feb 2021 19:38:42 +0000 (UTC) IronPort-SDR: yVJnUFKDSqdc1a2svxWYu93AVA9b8fGEAnEhA6Ygwwt6g5ae6txTPuv1OwWKYwlffNeO0wYlhq fafVXVa42GKw== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="244824654" X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="244824654" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 11:38:41 -0800 IronPort-SDR: ohgV4C/I1UePaCRez65ZgUn/NgBnaKShskuFwef7JJNyXUNfoy00nQfNOjD6SlMai1e3wjd6cy GpM2JuBuCXlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="391078770" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga008.jf.intel.com with SMTP; 01 Feb 2021 11:38:39 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 01 Feb 2021 21:38:38 +0200 Date: Mon, 1 Feb 2021 21:38:38 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Lucas De Marchi Message-ID: References: <20210201183343.15292-1-ville.syrjala@linux.intel.com> <20210201183343.15292-14-ville.syrjala@linux.intel.com> <20210201192239.aqdln6mbjveaqkub@ldmartin-desk1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 13/15] drm/i915: Split alds/rkl from icl_ddi_combo_{enable, disable}_clock() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 01, 2021 at 09:31:49PM +0200, Ville Syrj=E4l=E4 wrote: > On Mon, Feb 01, 2021 at 11:22:39AM -0800, Lucas De Marchi wrote: > > On Mon, Feb 01, 2021 at 08:33:41PM +0200, Ville Syrj=E4l=E4 wrote: > > >From: Ville Syrj=E4l=E4 > > > > > >Since .{enable,disable}_clock() are already vfuncs it's a bit silly to > > >have if-ladders inside them. Just provide specialized version for adlp > > >and rkl so we don't need any of that. > > = > > s/alds/adl-s/ > > = > > s/adlp/adl-s/ > > = > > = > > > > > >Signed-off-by: Ville Syrj=E4l=E4 > > >--- > > > drivers/gpu/drm/i915/display/intel_ddi.c | 93 ++++++++++++++++-------- > > > 1 file changed, 62 insertions(+), 31 deletions(-) > > > > > >diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/dr= m/i915/display/intel_ddi.c > > >index 1bd2aa86183d..bafb754d1b66 100644 > > >--- a/drivers/gpu/drm/i915/display/intel_ddi.c > > >+++ b/drivers/gpu/drm/i915/display/intel_ddi.c > > >@@ -3127,28 +3127,6 @@ static u32 icl_dpclka_cfgcr0_clk_off(struct drm= _i915_private *dev_priv, > > > return 0; > > > } > > > > > >-static u32 icl_dpclka_cfgcr0_clk_sel(struct drm_i915_private *dev_pri= v, > > >- enum intel_dpll_id id, enum phy phy) > > = > > ok, but why do we even add them in this series if we are going to > > remove. Just makes it harder to review. > = > I had to increase the SNR before I could see what the code was > trying to do. I guess I could now go back and drop the first > two patches. One counter argument would be that we already had icl_dpclka_cfgcr0_clk_off(), so not unifying the approach first means the other refactorings have to deal with two different styles, and thus could end up looking even more confusing. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx