From: Benson Leung <bleung@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Benson Leung <bleung@chromium.org>,
heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com,
pmalani@chromium.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kyletso@google.com
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision
Date: Tue, 2 Feb 2021 08:46:29 -0800 [thread overview]
Message-ID: <YBmB5QBciYoNRudT@google.com> (raw)
In-Reply-To: <YBl/0C4yc3ST9zLy@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Tue, Feb 02, 2021 at 05:37:36PM +0100, Greg KH wrote:
> On Tue, Feb 02, 2021 at 08:32:48AM -0800, Benson Leung wrote:
> > typec_partner_set_pd_revision returns void now.
> >
> > Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision from status
>
> Can you please use the documented format for the Fixes: tag (and for the
> use of any git id in the kernel changelog)?
D'oh. Thanks. I set up my pretty=fuller now.
Benson
>
> If anyone were to commit this change, you would get a nasty-gram email
> from linux-next :)
>
> thanks,
>
> greg k-h
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-02-02 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 16:32 [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision Benson Leung
2021-02-02 16:37 ` Benson Leung
2021-02-02 16:37 ` Greg KH
2021-02-02 16:46 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBmB5QBciYoNRudT@google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.