From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4CEC433E0 for ; Wed, 3 Feb 2021 10:25:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35FD264DE7 for ; Wed, 3 Feb 2021 10:25:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35FD264DE7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78E576EA4D; Wed, 3 Feb 2021 10:25:53 +0000 (UTC) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 337BB6EA4D for ; Wed, 3 Feb 2021 10:25:52 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id q7so23511543wre.13 for ; Wed, 03 Feb 2021 02:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=q8rg9C2aokhN+dfp78nPAipw2efrtf8qQOfb3+Ijz6o=; b=UWbdvd8Fx9pDmSMJhAAJlfsfVW41c/5a4i+hkYbLdEmZT29UqtBxqlWoWnD/D5izAz bKPzP8n7hCw+G/CDtq6gFZVBkmn0KFONhIwBYvn9fVNbpTWpTNwLT+/SlMVZJg4A4cKp hO5pR8+uCY07sdoDQnnzNm8q1N/vZZyLe3XMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=q8rg9C2aokhN+dfp78nPAipw2efrtf8qQOfb3+Ijz6o=; b=QsPeXWmCflcF936GpWA/xdqrvdOT7VtSFKnMa/R1/9SQEHO6JwVMj7C99nKald5jct nxZjA1/7NVJNoGFhVi1z5NfXOtaIn4YmkcZuEKIE/sViSQ/7wLuOsQLDQmPxPX8kms/g mklEewLWrsLdPxpENqv07jVL8hW5nl5k+ZjJRKe7MFbK9sPhwAFgiP1whoANgHLLI47m egIPzE5PZ7a80Up1hpOwze8l6im7xgBXnA01o794zDkw8ze0cpE4cE3M1QYvoWX0wY/H kzP3omV9SqpFNZ2snoJG9ZnKw4MD6D6v94XTtsoF4PTU2EprSllP8i96NbzY1euUSW4X VSkg== X-Gm-Message-State: AOAM532a/U+RGh8CxgcTe0xEEBueKWhuY6UUhKm03TlrXrNwIaghxaBu 4bkGSYiRd51G5dCYpEabI53Iow== X-Google-Smtp-Source: ABdhPJyphqZ2NUWMTT86jBdIqEiY+JiFMaXE9v2zI6m/eDoXTBOwVEZUwc1SCS1qZMZ3DxVO152L+w== X-Received: by 2002:adf:81e4:: with SMTP id 91mr2723103wra.161.1612347950868; Wed, 03 Feb 2021 02:25:50 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j17sm2112012wmc.28.2021.02.03.02.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 02:25:50 -0800 (PST) Date: Wed, 3 Feb 2021 11:25:48 +0100 From: Daniel Vetter To: Hridya Valsaraju Subject: Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs Message-ID: Mail-Followup-To: Hridya Valsaraju , Sumit Semwal , Christian Koenig , Android Kernel Team , kernel test robot , Greg KH , LKML , DRI mailing list , Linaro MM SIG , Hyesoo Yu , Suren Baghdasaryan , "open list:DMA BUFFER SHARING FRAMEWORK" References: <20210126204240.418297-1-hridya@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , Greg KH , LKML , DRI mailing list , Christian Koenig , Linaro MM SIG , Hyesoo Yu , Suren Baghdasaryan , Android Kernel Team , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCBGZWIgMDEsIDIwMjEgYXQgMDE6MDI6MzBQTSAtMDgwMCwgSHJpZHlhIFZhbHNhcmFq dSB3cm90ZToKPiBPbiBNb24sIEZlYiAxLCAyMDIxIGF0IDEwOjM3IEFNIERhbmllbCBWZXR0ZXIg PGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPgo+ID4gT24gVGh1LCBKYW4gMjgsIDIwMjEgYXQg MTowMyBQTSBTdW1pdCBTZW13YWwgPHN1bWl0LnNlbXdhbEBsaW5hcm8ub3JnPiB3cm90ZToKPiA+ ID4KPiA+ID4gT24gVGh1LCAyOCBKYW4gMjAyMSBhdCAxNzoyMywgQ2hyaXN0aWFuIEvDtm5pZwo+ ID4gPiA8Y2tvZW5pZy5sZWljaHR6dW1lcmtlbkBnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+Cj4g PiA+ID4gQW0gMjguMDEuMjEgdW0gMTI6MDAgc2NocmllYiBTdW1pdCBTZW13YWw6Cj4gPiA+ID4g PiBIaSBIcmlkeWEsCj4gPiA+ID4gPgo+ID4gPiA+ID4gT24gV2VkLCAyNyBKYW4gMjAyMSBhdCAx NzozNiwgR3JlZyBLSCA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+IHdyb3RlOgo+ID4gPiA+ ID4+IE9uIFR1ZSwgSmFuIDI2LCAyMDIxIGF0IDEyOjQyOjM2UE0gLTA4MDAsIEhyaWR5YSBWYWxz YXJhanUgd3JvdGU6Cj4gPiA+ID4gPj4+IFRoaXMgcGF0Y2ggYWxsb3dzIHN0YXRpc3RpY3MgdG8g YmUgZW5hYmxlZCBmb3IgZWFjaCBETUEtQlVGIGluCj4gPiA+ID4gPj4+IHN5c2ZzIGJ5IGVuYWJs aW5nIHRoZSBjb25maWcgQ09ORklHX0RNQUJVRl9TWVNGU19TVEFUUy4KPiA+ID4gPiA+Pj4KPiA+ ID4gPiA+Pj4gVGhlIGZvbGxvd2luZyBzdGF0cyB3aWxsIGJlIGV4cG9zZWQgYnkgdGhlIGludGVy ZmFjZToKPiA+ID4gPiA+Pj4KPiA+ID4gPiA+Pj4gL3N5cy9rZXJuZWwvZG1hYnVmL2J1ZmZlcnMv PGlub2RlX251bWJlcj4vZXhwb3J0ZXJfbmFtZQo+ID4gPiA+ID4+PiAvc3lzL2tlcm5lbC9kbWFi dWYvYnVmZmVycy88aW5vZGVfbnVtYmVyPi9zaXplCj4gPiA+ID4gPj4+IC9zeXMva2VybmVsL2Rt YWJ1Zi9idWZmZXJzLzxpbm9kZV9udW1iZXI+L2F0dGFjaG1lbnRzLzxhdHRhY2hfdWlkPi9kZXZp Y2UKPiA+ID4gPiA+Pj4gL3N5cy9rZXJuZWwvZG1hYnVmL2J1ZmZlcnMvPGlub2RlX251bWJlcj4v YXR0YWNobWVudHMvPGF0dGFjaF91aWQ+L21hcF9jb3VudGVyCj4gPiA+ID4gPj4+Cj4gPiA+ID4g Pj4+IFRoZSBpbm9kZV9udW1iZXIgaXMgdW5pcXVlIGZvciBlYWNoIERNQS1CVUYgYW5kIHdhcyBh ZGRlZCBlYXJsaWVyIFsxXQo+ID4gPiA+ID4+PiBpbiBvcmRlciB0byBhbGxvdyB1c2Vyc3BhY2Ug dG8gdHJhY2sgRE1BLUJVRiB1c2FnZSBhY3Jvc3MgZGlmZmVyZW50Cj4gPiA+ID4gPj4+IHByb2Nl c3Nlcy4KPiA+ID4gPiA+Pj4KPiA+ID4gPiA+Pj4gQ3VycmVudGx5LCB0aGlzIGluZm9ybWF0aW9u IGlzIGV4cG9zZWQgaW4KPiA+ID4gPiA+Pj4gL3N5cy9rZXJuZWwvZGVidWcvZG1hX2J1Zi9idWZp bmZvLgo+ID4gPiA+ID4+PiBIb3dldmVyLCBzaW5jZSBkZWJ1Z2ZzIGlzIGNvbnNpZGVyZWQgdW5z YWZlIHRvIGJlIG1vdW50ZWQgaW4gcHJvZHVjdGlvbiwKPiA+ID4gPiA+Pj4gaXQgaXMgYmVpbmcg ZHVwbGljYXRlZCBpbiBzeXNmcy4KPiA+ID4gPiA+Pj4KPiA+ID4gPiA+Pj4gVGhpcyBpbmZvcm1h dGlvbiB3aWxsIGJlIHVzZWQgdG8gZGVyaXZlIERNQS1CVUYKPiA+ID4gPiA+Pj4gcGVyLWV4cG9y dGVyIHN0YXRzIGFuZCBwZXItZGV2aWNlIHVzYWdlIHN0YXRzIGZvciBBbmRyb2lkIEJ1ZyByZXBv cnRzLgo+ID4gPiA+ID4+PiBUaGUgY29ycmVzcG9uZGluZyB1c2Vyc3BhY2UgY2hhbmdlcyBjYW4g YmUgZm91bmQgYXQgWzJdLgo+ID4gPiA+ID4+PiBUZWxlbWV0cnkgdG9vbHMgd2lsbCBhbHNvIGNh cHR1cmUgdGhpcyBpbmZvcm1hdGlvbihhbG9uZyB3aXRoIG90aGVyCj4gPiA+ID4gPj4+IG1lbW9y eSBtZXRyaWNzKSBwZXJpb2RpY2FsbHkgYXMgd2VsbCBhcyBvbiBpbXBvcnRhbnQgZXZlbnRzIGxp a2UgYQo+ID4gPiA+ID4+PiBmb3JlZ3JvdW5kIGFwcCBraWxsICh3aGljaCBtaWdodCBoYXZlIGJl ZW4gdHJpZ2dlcmVkIGJ5IExvdyBNZW1vcnkKPiA+ID4gPiA+Pj4gS2lsbGVyKS4gSXQgd2lsbCBh bHNvIGNvbnRyaWJ1dGUgdG8gcHJvdmlkZSBhIHNuYXBzaG90IG9mIHRoZSBzeXN0ZW0KPiA+ID4g PiA+Pj4gbWVtb3J5IHVzYWdlIG9uIG90aGVyIGV2ZW50cyBzdWNoIGFzIE9PTSBraWxscyBhbmQg QXBwbGljYXRpb24gTm90Cj4gPiA+ID4gPj4+IFJlc3BvbmRpbmcgZXZlbnRzLgo+ID4gPiA+ID4+ Pgo+ID4gPiA+ID4+PiBBIHNoZWxsIHNjcmlwdCB0aGF0IGNhbiBiZSBydW4gb24gYSBjbGFzc2lj IExpbnV4IGVudmlyb25tZW50IHRvIHJlYWQKPiA+ID4gPiA+Pj4gb3V0IHRoZSBETUEtQlVGIHN0 YXRpc3RpY3MgY2FuIGJlIGZvdW5kIGF0IFszXShzdWdnZXN0ZWQgYnkgSm9obgo+ID4gPiA+ID4+ PiBTdHVsdHopLgo+ID4gPiA+ID4+Pgo+ID4gPiA+ID4+PiBUaGUgcGF0Y2ggY29udGFpbnMgdGhl IGZvbGxvd2luZyBpbXByb3ZlbWVudHMgb3ZlciB0aGUgcHJldmlvdXMgdmVyc2lvbjoKPiA+ID4g PiA+Pj4gMSkgRWFjaCBhdHRhY2htZW50IGlzIHJlcHJlc2VudGVkIGJ5IGl0cyBvd24gZGlyZWN0 b3J5IHRvIGFsbG93IGNyZWF0aW5nCj4gPiA+ID4gPj4+IGEgc3ltbGluayB0byB0aGUgaW1wb3J0 aW5nIGRldmljZSBhbmQgdG8gYWxzbyBwcm92aWRlIHJvb20gZm9yIGZ1dHVyZQo+ID4gPiA+ID4+ PiBleHBhbnNpb24uCj4gPiA+ID4gPj4+IDIpIFRoZSBudW1iZXIgb2YgZGlzdGluY3QgbWFwcGlu Z3Mgb2YgZWFjaCBhdHRhY2htZW50IGlzIGV4cG9zZWQgaW4gYQo+ID4gPiA+ID4+PiBzZXBhcmF0 ZSBmaWxlLgo+ID4gPiA+ID4+PiAzKSBUaGUgcGVyLWJ1ZmZlciBzdGF0aXN0aWNzIGFyZSBub3cg aW4gL3N5cy9rZXJuZWwvZG1hYnVmL2J1ZmZlcnMKPiA+ID4gPiA+Pj4gaW5vcmRlciB0byBtYWtl IHRoZSBpbnRlcmZhY2UgZXhwYW5kYWJsZSBpbiBmdXR1cmUuCj4gPiA+ID4gPj4+Cj4gPiA+ID4g Pj4+IEFsbCBvZiB0aGUgaW1wcm92ZW1lbnRzIGFib3ZlIGFyZSBiYXNlZCBvbiBzdWdnZXN0aW9u cy9mZWVkYmFjayBmcm9tCj4gPiA+ID4gPj4+IERhbmllbCBWZXR0ZXIgYW5kIENocmlzdGlhbiBL w7ZuaWcuCj4gPiA+ID4gPj4+Cj4gPiA+ID4gPj4+IFsxXTogaHR0cHM6Ly9sb3JlLmtlcm5lbC5v cmcvcGF0Y2h3b3JrL3BhdGNoLzEwODg3OTEvCj4gPiA+ID4gPj4+IFsyXTogaHR0cHM6Ly9hbmRy b2lkLXJldmlldy5nb29nbGVzb3VyY2UuY29tL3EvdG9waWM6JTIyZG1hYnVmLXN5c2ZzJTIyKyhz dGF0dXM6b3BlbiUyME9SJTIwc3RhdHVzOm1lcmdlZCkKPiA+ID4gPiA+Pj4gWzNdOiBodHRwczov L2FuZHJvaWQtcmV2aWV3Lmdvb2dsZXNvdXJjZS5jb20vYy9wbGF0Zm9ybS9zeXN0ZW0vbWVtb3J5 L2xpYm1lbWluZm8vKy8xNTQ5NzM0Cj4gPiA+ID4gPj4+Cj4gPiA+ID4gPj4+IFNpZ25lZC1vZmYt Ynk6IEhyaWR5YSBWYWxzYXJhanUgPGhyaWR5YUBnb29nbGUuY29tPgo+ID4gPiA+ID4+PiBSZXBv cnRlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Cj4gPiA+ID4gPiBUaGFu a3MgZm9yIHRoZSBwYXRjaCEKPiA+ID4gPiA+Cj4gPiA+ID4gPiBDaHJpc3RpYW46IElmIHlvdSdy ZSBzYXRpc2ZpZWQgd2l0aCB0aGUgZXhwbGFuYXRpb24gYXJvdW5kIG5vdAo+ID4gPiA+ID4gZGly ZWN0bHkgZW1iZWRkaW5nIGtvYmplY3RzIGludG8gdGhlIGRtYV9idWYgYW5kIGRtYV9idWZfYXR0 YWNobWVudAo+ID4gPiA+ID4gc3RydWN0cywgdGhlbiB3aXRoIEdyZWcncyByLWIgZnJvbSBzeXNm cyBQb1YsIEkgdGhpbmsgd2UgY2FuIG1lcmdlIGl0Lgo+ID4gPiA+ID4gUGxlYXNlIGxldCBtZSBr bm93IGlmIHlvdSBmZWVsIG90aGVyd2lzZSEKPiA+ID4gPgo+ID4gPiA+ICBGcm9tIHRoZSB0ZWNo bmljYWwgc2lkZSBpdCBsb29rcyBjbGVhbiB0byBtZSwgZmVlbCBmcmVlIHRvIGFkZCBteQo+ID4g PiA+IGFja2VkLWJ5IHdoaWxlIHB1c2hpbmcuCj4gPiA+ID4KPiA+ID4gPiBCdXQgSSB3b3VsZCBh dCBsZWFzdCB0cnkgdG8gY29udmluY2UgRGFuaWVsIG9uIHRoZSBkZXNpZ24uIEF0IGxlYXN0IHNv bWUKPiA+ID4gPiBvZiBoaXMgY29uY2VybnMgc2VlbXMgdG8gYmUgdmFsaWQgYW5kIGtlZXAgaW4g bWluZCB0aGF0IHdlIG5lZWQgdG8KPiA+ID4gPiBzdXBwb3J0IHRoaXMgaW50ZXJmYWNlIGZvcmV2 ZXIuCj4gPiA+Cj4gPiA+IE5hdHVyYWxseS4KPiA+ID4KPiA+ID4gU2luY2UgaGUgZGlkbid0IGNv bW1lbnQgb3ZlciBIcmlkeWEncyBsYXN0IGNsYXJpZmljYXRpb24gYWJvdXQgdGhlCj4gPiA+IHRy YWNlcG9pbnRzIHRvIHRyYWNrIHRvdGFsIEdQVSBtZW1vcnkgYWxsb2NhdGlvbnMgYmVpbmcgb3J0 aG9nb25hbCB0bwo+ID4gPiB0aGlzIHNlcmllcywgSSBhc3N1bWVkIGhlIGFncmVlZCB3aXRoIGl0 Lgo+ID4KPiA+IFRoZSB0cmFjZXBvaW50IGJlaW5nIG9ydGhvZ29uYWwgZGlkbid0IHJlYWxseSBs b29rIGNvbnZpbmNpbmcgdG8gbWUsCj4gPiBzaW5jZSBJIGRvIGV4cGVjdCB3ZSdsbCBuZWVkIHRo YXQgYXQgYSBtdWNoIG1vcmUgZ2VuZXJpYyBsZXZlbCwgYXQKPiA+IGFsbG9jYXRvcnMuIFdoZXRo ZXIgdGhhdCdzIGRtYS1idWYgaGVhcHMgb3IgaW4gZHJtIG9yIHdoZXJldmVyLiBBbmQgd2UKPiA+ IHByb2JhYmx5IGFsc28gbmVlZCB0aGF0IHRvIHNvbWVob3cgYWxpZ24gd2l0aCBjZ3JvdXBzIGFj Y291bnRpbmcuCj4gPgo+ID4gQnV0IEkgZ3Vlc3MgZm9yIHRoaXMgaXQgc2hvdWxkIGJlIGVhc3kg dG8gZXh0ZW5kIGhvd2V2ZXIgd2Ugc2VlIGZpdCwKPiA+IHNvIHJldHJvZml0dGluZyBhbGxvY2F0 b3Igc291cmNlcyBhbmQgYW55dGhpbmcgZWxzZSB3ZSB3YW50L25lZWQgZm9yCj4gPiB0aGUgb3Zl cmFsbCBncHUgbWVtb3J5IGFjY291bnQgc2hvdWxkbid0IGJlIGEgcHJvYmxlbS4gQWxzbywgaXQn cwo+ID4gZmlyc3QsIHNvIHRoZSBwcm9vZiBmb3Igc2hvd2luZyBpdCBhbGwgd29ya3MgdG9nZXRo ZXIgaXMgbW9yZSBvbiB0aGUKPiA+IHRyYWNlcG9pbnRzIDotKQo+ID4KPiA+ID4gRGFuaWVsLCBk byB5b3Ugc3RpbGwgaGF2ZSBvYmplY3Rpb25zIGFyb3VuZCBhZGRpbmcgdGhpcyBwYXRjaCBpbj8K PiA+Cj4gPiBOZWVkcyBkb2NzIChlc3BlY2lhbGx5IHRoZSB1YXBpIEkgdGhpbmsgd291bGQgYmUg dXNlZnVsIHRvIGRvY3VtZW50KSwKPiA+IGlndCB0ZXN0cywgdGhhdCBraW5kIG9mIHN0dWZmIHN0 aWxsIEkgdGhpbms/IEl0J3MgbWVhbnQgdG8gYmUgZ2VuZXJpYwo+ID4gdWFwaSBhY3Jvc3MgZHJp dmVycywgZ2VuZXJhbGx5IHdlJ3JlIGEgcGlsZSBzdHJpY3RlciBmb3IgdGhhdCAoYW5kIHllcwo+ ID4gZG1hLWJ1ZiBoZWFwcyBJIHRoaW5rIGRpZG4ndCBkbyBhbGwgdGhhdCwgc28gbWF5YmUgdGhl cmUncyBhbiBhcmd1bWVudAo+ID4gZm9yIGRvaW5nIHRoaXMgYSBiaXQgbW9yZSBzbG9wcHkgb3Ig YXQgbGVhc3QgInRoZSB0ZXN0c3VpdGUgaXMKPiA+IHNvbWV3aGVyZSBlbHNlIikuCj4gCj4gVGhh bmsgeW91IGZvciB0YWtpbmcgYW5vdGhlciBsb29rIERhbmllbCEKPiAKPiBJIHdpbGwgdHJ5IGFk ZGluZyBhbiBJR1QgdGVzdCBmb3IgdGhlIHN5c2ZzIGZpbGVzLiBPdGhlciB0aGFuIHRoZQo+IGRv Y3VtZW50YXRpb24gaW4KPiBEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWtlcm5lbC1k bWFidWYtYnVmZmVycyhpbmNsdWRlZCBpbiB0aGUKPiBwYXRjaCksIGlzIHRoZXJlIGFub3RoZXIg cGxhY2UgeW91IHdvdWxkIGxpa2UgdG8gc2VlIHRoZSBkb2N1bWVudGF0aW9uCj4gY29waWVkIHRv PwoKU28ganVzdCByZWFkIHRoZSBvdGhlciB0aHJlYWQsIGFuZCBzb3VuZHMgbGlrZSBDaHJpc3Rp YW4gS8O2bmlnIGJyb3VnaHQgdXAKYSBzb2xpZCBjb25jZXJuIHdpdGggZG1hLWJ1ZiBmZHMgZ2Vu ZXJhbGx5IG5vdCBzdGF5aW5nIGFyb3VuZCBmb3IgbXVjaC4KClNvIEknbSBsZWFuaW5nIG1vcmUg dG93YXJkcyAidGhpcyBzb3VuZHMgbGlrZSBpdCdzIGdvaW5nIHRvIGJlIHVzZWZ1bCBmb3IKQW5k cm9pZCBvbmx5LCBub3RoaW5nIGVsc2UiIGNvbmNlcm4uCi1EYW5pZWwKCj4gCj4gUmVnYXJkcywK PiBIcmlkeWEKPiAKPiA+Cj4gPiBCdXQgSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIHRvIGhhdmUg dGhpcyBhbGwgZG9uZS4KPiA+IC1EYW5pZWwKPiA+Cj4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBSZWdh cmRzLAo+ID4gPiA+IENocmlzdGlhbi4KPiA+ID4KPiA+ID4gQmVzdCwKPiA+ID4gU3VtaXQuCj4g PiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPj4+IC0tLQo+ID4gPiA+ID4+PiBDaGFuZ2VzIGluIHYz Ogo+ID4gPiA+ID4+PiBGaXggYSB3YXJuaW5nIHJlcG9ydGVkIGJ5IHRoZSBrZXJuZWwgdGVzdCBy b2JvdC4KPiA+ID4gPiA+Pj4KPiA+ID4gPiA+Pj4gQ2hhbmdlcyBpbiB2MjoKPiA+ID4gPiA+Pj4g LU1vdmUgc3RhdGlzdGljcyB0byAvc3lzL2tlcm5lbC9kbWFidWYvYnVmZmVycyBpbiBvZGVyIHRv IGFsbG93IGFkZGl0aW9uCj4gPiA+ID4gPj4+IG9mIG90aGVyIERNQS1CVUYtcmVsYXRlZCBzeXNm cyBzdGF0cyBpbiBmdXR1cmUuIEJhc2VkIG9uIGZlZWRiYWNrIGZyb20KPiA+ID4gPiA+Pj4gRGFu aWVsIFZldHRlci4KPiA+ID4gPiA+Pj4gLUVhY2ggYXR0YWNobWVudCBoYXMgaXRzIG93biBkaXJl Y3RvcnkgdG8gcmVwcmVzZW50IGF0dGFjaGluZyBkZXZpY2VzIGFzCj4gPiA+ID4gPj4+IHN5bWxp bmtzIGFuZCB0byBpbnRyb2R1Y2UgbWFwX2NvdW50IGFzIGEgc2VwYXJhdGUgZmlsZS4gQmFzZWQg b24KPiA+ID4gPiA+Pj4gZmVlZGJhY2sgZnJvbSBEYW5pZWwgVmV0dGVyIGFuZCBDaHJpc3RpYW4g S8O2bmlnLiBUaGFuayB5b3UgYm90aCEKPiA+ID4gPiA+Pj4gLUNvbW1pdCBtZXNzYWdlcyB1cGRh dGVkIHRvIHBvaW50IHRvIHVzZXJzcGFjZSBjb2RlIGluIEFPU1AgdGhhdCB3aWxsCj4gPiA+ID4g Pj4+IHJlYWQgdGhlIERNQS1CVUYgc3lzZnMgc3RhdHMuCj4gPiA+ID4gPj4+Cj4gPiA+ID4gPj4+ Cj4gPiA+ID4gPj4+ICAgLi4uL0FCSS90ZXN0aW5nL3N5c2ZzLWtlcm5lbC1kbWFidWYtYnVmZmVy cyAgIHwgIDUyICsrKysKPiA+ID4gPiA+Pj4gICBkcml2ZXJzL2RtYS1idWYvS2NvbmZpZyAgICAg ICAgICAgICAgICAgICAgICAgfCAgMTEgKwo+ID4gPiA+ID4+PiAgIGRyaXZlcnMvZG1hLWJ1Zi9N YWtlZmlsZSAgICAgICAgICAgICAgICAgICAgICB8ICAgMSArCj4gPiA+ID4gPj4+ICAgZHJpdmVy cy9kbWEtYnVmL2RtYS1idWYtc3lzZnMtc3RhdHMuYyAgICAgICAgIHwgMjg1ICsrKysrKysrKysr KysrKysrKwo+ID4gPiA+ID4+PiAgIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLXN5c2ZzLXN0YXRz LmggICAgICAgICB8ICA2MiArKysrCj4gPiA+ID4gPj4+ICAgZHJpdmVycy9kbWEtYnVmL2RtYS1i dWYuYyAgICAgICAgICAgICAgICAgICAgIHwgIDM3ICsrKwo+ID4gPiA+ID4+PiAgIGluY2x1ZGUv bGludXgvZG1hLWJ1Zi5oICAgICAgICAgICAgICAgICAgICAgICB8ICAyMCArKwo+ID4gPiA+ID4+ PiAgIDcgZmlsZXMgY2hhbmdlZCwgNDY4IGluc2VydGlvbnMoKykKPiA+ID4gPiA+Pj4gICBjcmVh dGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1rZXJuZWwtZG1h YnVmLWJ1ZmZlcnMKPiA+ID4gPiA+Pj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9kbWEt YnVmL2RtYS1idWYtc3lzZnMtc3RhdHMuYwo+ID4gPiA+ID4+PiAgIGNyZWF0ZSBtb2RlIDEwMDY0 NCBkcml2ZXJzL2RtYS1idWYvZG1hLWJ1Zi1zeXNmcy1zdGF0cy5oCj4gPiA+ID4gPj4gSSBkb24n dCBrbm93IHRoZSBkbWEtYnVmIGNvZGUgYXQgYWxsLCBidXQgZnJvbSBhIHN5c2ZzL2tvYmplY3Qg cG9pbnQgb2YKPiA+ID4gPiA+PiB2aWV3LCB0aGlzIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWU6Cj4g PiA+ID4gPj4KPiA+ID4gPiA+PiBSZXZpZXdlZC1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVn a2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPiA+ID4gPiA+IEJlc3QsCj4gPiA+ID4gPiBTdW1pdC4K PiA+ID4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gPiA+ID4gPiBMaW5hcm8tbW0tc2lnIG1haWxpbmcgbGlzdAo+ID4gPiA+ID4gTGluYXJvLW1t LXNpZ0BsaXN0cy5saW5hcm8ub3JnCj4gPiA+ID4gPiBodHRwczovL2xpc3RzLmxpbmFyby5vcmcv bWFpbG1hbi9saXN0aW5mby9saW5hcm8tbW0tc2lnCj4gPiA+ID4KPiA+ID4KPiA+ID4KPiA+ID4g LS0KPiA+ID4gVGhhbmtzIGFuZCByZWdhcmRzLAo+ID4gPgo+ID4gPiBTdW1pdCBTZW13YWwKPiA+ ID4gTGluYXJvIENvbnN1bWVyIEdyb3VwIC0gVGVjaCBMZWFkCj4gPiA+IExpbmFyby5vcmcg4pSC IE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29Dcwo+ID4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBkcmktZGV2ZWwgbWFpbGluZyBs aXN0Cj4gPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiA+Cj4gPgo+ ID4KPiA+IC0tCj4gPiBEYW5pZWwgVmV0dGVyCj4gPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KPiA+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 580D8C433DB for ; Wed, 3 Feb 2021 10:27:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F309364E34 for ; Wed, 3 Feb 2021 10:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233640AbhBCK1b (ORCPT ); Wed, 3 Feb 2021 05:27:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233840AbhBCK0c (ORCPT ); Wed, 3 Feb 2021 05:26:32 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2555FC0613ED for ; Wed, 3 Feb 2021 02:25:52 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id d16so23498567wro.11 for ; Wed, 03 Feb 2021 02:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=q8rg9C2aokhN+dfp78nPAipw2efrtf8qQOfb3+Ijz6o=; b=UWbdvd8Fx9pDmSMJhAAJlfsfVW41c/5a4i+hkYbLdEmZT29UqtBxqlWoWnD/D5izAz bKPzP8n7hCw+G/CDtq6gFZVBkmn0KFONhIwBYvn9fVNbpTWpTNwLT+/SlMVZJg4A4cKp hO5pR8+uCY07sdoDQnnzNm8q1N/vZZyLe3XMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=q8rg9C2aokhN+dfp78nPAipw2efrtf8qQOfb3+Ijz6o=; b=IDkm3gOnjhtnt0kJ7o1M52m2sFfcr9aStzX/GMC2w4mn2fVWP9du5St3L2Yn403rFg TXy8wb+VxbknNIffLUw0YZYMnwCwt6EMpQGWE1sqOm6ypXyTifjDyxK+mgeDn9cp0URO /zR8ltZST0HX4x7WbotVtwxPEJiBfvFfl22Jp6NqKEHqCecsaw1AxsPkUsrTSmXvh2kK LXEZ8HWZ/1+Ysgz4YKLrWaqc1YhFguJV9fzKas4vqLgMj1e4tnPMNQEF5lPWWrOZdyeR UOAiHu9AawC/8DBdvgZ5+KK2S29zDdNsj2kCBxZxsdqPypFiOHcBEq1VUFwgJaYv4tLJ 6piQ== X-Gm-Message-State: AOAM531FrsKPEs1rBuxDgDrdqY3s1N6AphigN7xqspvZWUSrbH6Uacuy Y8lz3aiUCGTzp6RgLBypaqnovA== X-Google-Smtp-Source: ABdhPJyphqZ2NUWMTT86jBdIqEiY+JiFMaXE9v2zI6m/eDoXTBOwVEZUwc1SCS1qZMZ3DxVO152L+w== X-Received: by 2002:adf:81e4:: with SMTP id 91mr2723103wra.161.1612347950868; Wed, 03 Feb 2021 02:25:50 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j17sm2112012wmc.28.2021.02.03.02.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 02:25:50 -0800 (PST) Date: Wed, 3 Feb 2021 11:25:48 +0100 From: Daniel Vetter To: Hridya Valsaraju Cc: Daniel Vetter , Sumit Semwal , Christian Koenig , Android Kernel Team , kernel test robot , Greg KH , LKML , DRI mailing list , Linaro MM SIG , Hyesoo Yu , Suren Baghdasaryan , "open list:DMA BUFFER SHARING FRAMEWORK" Subject: Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs Message-ID: Mail-Followup-To: Hridya Valsaraju , Sumit Semwal , Christian Koenig , Android Kernel Team , kernel test robot , Greg KH , LKML , DRI mailing list , Linaro MM SIG , Hyesoo Yu , Suren Baghdasaryan , "open list:DMA BUFFER SHARING FRAMEWORK" References: <20210126204240.418297-1-hridya@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Feb 01, 2021 at 01:02:30PM -0800, Hridya Valsaraju wrote: > On Mon, Feb 1, 2021 at 10:37 AM Daniel Vetter wrote: > > > > On Thu, Jan 28, 2021 at 1:03 PM Sumit Semwal wrote: > > > > > > On Thu, 28 Jan 2021 at 17:23, Christian König > > > wrote: > > > > > > > > Am 28.01.21 um 12:00 schrieb Sumit Semwal: > > > > > Hi Hridya, > > > > > > > > > > On Wed, 27 Jan 2021 at 17:36, Greg KH wrote: > > > > >> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: > > > > >>> This patch allows statistics to be enabled for each DMA-BUF in > > > > >>> sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. > > > > >>> > > > > >>> The following stats will be exposed by the interface: > > > > >>> > > > > >>> /sys/kernel/dmabuf/buffers//exporter_name > > > > >>> /sys/kernel/dmabuf/buffers//size > > > > >>> /sys/kernel/dmabuf/buffers//attachments//device > > > > >>> /sys/kernel/dmabuf/buffers//attachments//map_counter > > > > >>> > > > > >>> The inode_number is unique for each DMA-BUF and was added earlier [1] > > > > >>> in order to allow userspace to track DMA-BUF usage across different > > > > >>> processes. > > > > >>> > > > > >>> Currently, this information is exposed in > > > > >>> /sys/kernel/debug/dma_buf/bufinfo. > > > > >>> However, since debugfs is considered unsafe to be mounted in production, > > > > >>> it is being duplicated in sysfs. > > > > >>> > > > > >>> This information will be used to derive DMA-BUF > > > > >>> per-exporter stats and per-device usage stats for Android Bug reports. > > > > >>> The corresponding userspace changes can be found at [2]. > > > > >>> Telemetry tools will also capture this information(along with other > > > > >>> memory metrics) periodically as well as on important events like a > > > > >>> foreground app kill (which might have been triggered by Low Memory > > > > >>> Killer). It will also contribute to provide a snapshot of the system > > > > >>> memory usage on other events such as OOM kills and Application Not > > > > >>> Responding events. > > > > >>> > > > > >>> A shell script that can be run on a classic Linux environment to read > > > > >>> out the DMA-BUF statistics can be found at [3](suggested by John > > > > >>> Stultz). > > > > >>> > > > > >>> The patch contains the following improvements over the previous version: > > > > >>> 1) Each attachment is represented by its own directory to allow creating > > > > >>> a symlink to the importing device and to also provide room for future > > > > >>> expansion. > > > > >>> 2) The number of distinct mappings of each attachment is exposed in a > > > > >>> separate file. > > > > >>> 3) The per-buffer statistics are now in /sys/kernel/dmabuf/buffers > > > > >>> inorder to make the interface expandable in future. > > > > >>> > > > > >>> All of the improvements above are based on suggestions/feedback from > > > > >>> Daniel Vetter and Christian König. > > > > >>> > > > > >>> [1]: https://lore.kernel.org/patchwork/patch/1088791/ > > > > >>> [2]: https://android-review.googlesource.com/q/topic:%22dmabuf-sysfs%22+(status:open%20OR%20status:merged) > > > > >>> [3]: https://android-review.googlesource.com/c/platform/system/memory/libmeminfo/+/1549734 > > > > >>> > > > > >>> Signed-off-by: Hridya Valsaraju > > > > >>> Reported-by: kernel test robot > > > > > Thanks for the patch! > > > > > > > > > > Christian: If you're satisfied with the explanation around not > > > > > directly embedding kobjects into the dma_buf and dma_buf_attachment > > > > > structs, then with Greg's r-b from sysfs PoV, I think we can merge it. > > > > > Please let me know if you feel otherwise! > > > > > > > > From the technical side it looks clean to me, feel free to add my > > > > acked-by while pushing. > > > > > > > > But I would at least try to convince Daniel on the design. At least some > > > > of his concerns seems to be valid and keep in mind that we need to > > > > support this interface forever. > > > > > > Naturally. > > > > > > Since he didn't comment over Hridya's last clarification about the > > > tracepoints to track total GPU memory allocations being orthogonal to > > > this series, I assumed he agreed with it. > > > > The tracepoint being orthogonal didn't really look convincing to me, > > since I do expect we'll need that at a much more generic level, at > > allocators. Whether that's dma-buf heaps or in drm or wherever. And we > > probably also need that to somehow align with cgroups accounting. > > > > But I guess for this it should be easy to extend however we see fit, > > so retrofitting allocator sources and anything else we want/need for > > the overall gpu memory account shouldn't be a problem. Also, it's > > first, so the proof for showing it all works together is more on the > > tracepoints :-) > > > > > Daniel, do you still have objections around adding this patch in? > > > > Needs docs (especially the uapi I think would be useful to document), > > igt tests, that kind of stuff still I think? It's meant to be generic > > uapi across drivers, generally we're a pile stricter for that (and yes > > dma-buf heaps I think didn't do all that, so maybe there's an argument > > for doing this a bit more sloppy or at least "the testsuite is > > somewhere else"). > > Thank you for taking another look Daniel! > > I will try adding an IGT test for the sysfs files. Other than the > documentation in > Documentation/ABI/testing/sysfs-kernel-dmabuf-buffers(included in the > patch), is there another place you would like to see the documentation > copied to? So just read the other thread, and sounds like Christian König brought up a solid concern with dma-buf fds generally not staying around for much. So I'm leaning more towards "this sounds like it's going to be useful for Android only, nothing else" concern. -Daniel > > Regards, > Hridya > > > > > But I think it would be good to have this all done. > > -Daniel > > > > > > > > > > > > > Regards, > > > > Christian. > > > > > > Best, > > > Sumit. > > > > > > > > > > > > > >>> --- > > > > >>> Changes in v3: > > > > >>> Fix a warning reported by the kernel test robot. > > > > >>> > > > > >>> Changes in v2: > > > > >>> -Move statistics to /sys/kernel/dmabuf/buffers in oder to allow addition > > > > >>> of other DMA-BUF-related sysfs stats in future. Based on feedback from > > > > >>> Daniel Vetter. > > > > >>> -Each attachment has its own directory to represent attaching devices as > > > > >>> symlinks and to introduce map_count as a separate file. Based on > > > > >>> feedback from Daniel Vetter and Christian König. Thank you both! > > > > >>> -Commit messages updated to point to userspace code in AOSP that will > > > > >>> read the DMA-BUF sysfs stats. > > > > >>> > > > > >>> > > > > >>> .../ABI/testing/sysfs-kernel-dmabuf-buffers | 52 ++++ > > > > >>> drivers/dma-buf/Kconfig | 11 + > > > > >>> drivers/dma-buf/Makefile | 1 + > > > > >>> drivers/dma-buf/dma-buf-sysfs-stats.c | 285 ++++++++++++++++++ > > > > >>> drivers/dma-buf/dma-buf-sysfs-stats.h | 62 ++++ > > > > >>> drivers/dma-buf/dma-buf.c | 37 +++ > > > > >>> include/linux/dma-buf.h | 20 ++ > > > > >>> 7 files changed, 468 insertions(+) > > > > >>> create mode 100644 Documentation/ABI/testing/sysfs-kernel-dmabuf-buffers > > > > >>> create mode 100644 drivers/dma-buf/dma-buf-sysfs-stats.c > > > > >>> create mode 100644 drivers/dma-buf/dma-buf-sysfs-stats.h > > > > >> I don't know the dma-buf code at all, but from a sysfs/kobject point of > > > > >> view, this patch looks good to me: > > > > >> > > > > >> Reviewed-by: Greg Kroah-Hartman > > > > > Best, > > > > > Sumit. > > > > > _______________________________________________ > > > > > Linaro-mm-sig mailing list > > > > > Linaro-mm-sig@lists.linaro.org > > > > > https://lists.linaro.org/mailman/listinfo/linaro-mm-sig > > > > > > > > > > > > > -- > > > Thanks and regards, > > > > > > Sumit Semwal > > > Linaro Consumer Group - Tech Lead > > > Linaro.org │ Open source software for ARM SoCs > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch