From: sdf@google.com
To: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Hariharan Ananthakrishnan <hari@netflix.com>,
"David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Song Liu <songliubraving@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Brendan Gregg <bgregg@netflix.com>
Subject: Re: [PATCH] net: tracepoint: exposing sk_family in all tcp:tracepoints
Date: Wed, 3 Feb 2021 08:26:04 -0800 [thread overview]
Message-ID: <YBrOnJvBGKi0aa7G@google.com> (raw)
In-Reply-To: <CANn89i+ZggZvj_bEo7Jd+Ac=kiE9SZGxJ7JQ=NVTHCkM97jE6g@mail.gmail.com>
On 02/02, Eric Dumazet wrote:
> On Mon, Feb 1, 2021 at 11:06 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Fri, 29 Jan 2021 00:12:10 +0000 Hariharan Ananthakrishnan wrote:
> > > Similar to sock:inet_sock_set_state tracepoint, expose sk_family to
> > > distinguish AF_INET and AF_INET6 families.
> > >
> > > The following tcp tracepoints are updated:
> > > tcp:tcp_destroy_sock
> > > tcp:tcp_rcv_space_adjust
> > > tcp:tcp_retransmit_skb
> > > tcp:tcp_send_reset
> > > tcp:tcp_receive_reset
> > > tcp:tcp_retransmit_synack
> > > tcp:tcp_probe
> > >
> > > Signed-off-by: Hariharan Ananthakrishnan <hari@netflix.com>
> > > Signed-off-by: Brendan Gregg <bgregg@netflix.com>
> >
> > Eric, any thoughts?
> I do not use these tracepoints in production scripts, but I wonder if
> existing tools could break after this change ?
> Or do we consider tracepoints format is not part of the ABI and can be
> arbitrarily changed by anyone ?
They are not ABI and since we are extending tracepoints with additional
info (and not removing any existing fields) it shouldn't be a problem.
next prev parent reply other threads:[~2021-02-03 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 0:12 [PATCH] net: tracepoint: exposing sk_family in all tcp:tracepoints Hariharan Ananthakrishnan
2021-01-29 0:16 ` Alexei Starovoitov
2021-01-29 0:53 ` Brendan Gregg
2021-02-01 22:06 ` Jakub Kicinski
2021-02-02 7:38 ` Eric Dumazet
2021-02-03 16:26 ` sdf [this message]
2021-02-03 18:16 ` Jakub Kicinski
2021-02-03 18:25 ` Hariharan Ananthakrishnan
2021-02-03 18:44 ` Jakub Kicinski
2021-02-04 17:26 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBrOnJvBGKi0aa7G@google.com \
--to=sdf@google.com \
--cc=ast@kernel.org \
--cc=bgregg@netflix.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hari@netflix.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.