All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ye Bin <yebin10@huawei.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision
Date: Thu, 4 Feb 2021 07:22:20 +0100	[thread overview]
Message-ID: <YBuSnPDbrXcnBcgZ@kroah.com> (raw)
In-Reply-To: <20210204012430.3686636-1-yebin10@huawei.com>

On Thu, Feb 04, 2021 at 09:24:30AM +0800, Ye Bin wrote:
> Fix follow warning:
> drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ [-Wunused-variable]
>   int ret;
>       ^~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
>  drivers/usb/typec/class.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index b6ceab3dc16b..1c2d50e016e2 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -760,8 +760,6 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
>   */
>  int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
>  {
> -	int ret;
> -
>  	if (partner->pd_revision == pd_revision)
>  		return 0;
>  

This is already fixed in my tree, right?  What did you make this
against?

thanks,

greg k-h

      reply	other threads:[~2021-02-04  6:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  1:24 [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision Ye Bin
2021-02-04  6:22 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBuSnPDbrXcnBcgZ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hulkci@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=yebin10@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.