From: Greg KH <gregkh@linuxfoundation.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: vincenzo.frascino@arm.com, mark.rutland@arm.com,
stable@vger.kernel.org, will@kernel.org
Subject: Re: FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree
Date: Thu, 4 Feb 2021 16:27:28 +0100 [thread overview]
Message-ID: <YBwSYDlp9HTtFNCb@kroah.com> (raw)
In-Reply-To: <20210204151251.GD14155@gaia>
On Thu, Feb 04, 2021 at 03:12:52PM +0000, Catalin Marinas wrote:
> On Thu, Feb 04, 2021 at 04:08:02PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 03, 2021 at 01:15:03PM +0000, Catalin Marinas wrote:
> > > On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote:
> > > > From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
> > > > From: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > > Date: Tue, 26 Jan 2021 13:40:56 +0000
> > > > Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()
> > > >
> > > > Currently, the __is_lm_address() check just masks out the top 12 bits
> > > > of the address, but if they are 0, it still yields a true result.
> > > > This has as a side effect that virt_addr_valid() returns true even for
> > > > invalid virtual addresses (e.g. 0x0).
> > > >
> > > > Fix the detection checking that it's actually a kernel address starting
> > > > at PAGE_OFFSET.
> > > >
> > > > Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
> > > > Cc: <stable@vger.kernel.org> # 5.4.x
> > > > Cc: Will Deacon <will@kernel.org>
> > > > Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> > > > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> > > > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > > Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@arm.com
> > > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > >
> > > I sent you the 5.4 and 5.10 backports of this patch. There is another
> > > fix in this area which I'll send to Linus tonight. It should apply
> > > cleanly on 5.4 and 5.10.
> >
> > Both now applied. What is the git id of the other fix in Linus's tree?
>
> Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged
> addresses to __is_lm_address()").
Great, grabbed that now too, thanks.
greg k-h
next prev parent reply other threads:[~2021-02-04 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1612104058247187@kroah.com>
2021-02-03 13:15 ` FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree Catalin Marinas
2021-02-04 15:08 ` Greg KH
2021-02-04 15:12 ` Catalin Marinas
2021-02-04 15:27 ` Greg KH [this message]
2021-02-04 15:28 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBwSYDlp9HTtFNCb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=catalin.marinas@arm.com \
--cc=mark.rutland@arm.com \
--cc=stable@vger.kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.