From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@redhat.com>,
intel-gfx@lists.freedesktop.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [Intel-gfx] [PATCH v11 03/10] drm/i915: migrate skl planes code new file (v5)
Date: Thu, 4 Feb 2021 22:28:25 +0200 [thread overview]
Message-ID: <YBxY6VV00sNJ/rqR@intel.com> (raw)
In-Reply-To: <b84e4d31c02dc9722522b003958ffbe12837e58b.1612467466.git.jani.nikula@intel.com>
On Thu, Feb 04, 2021 at 09:43:20PM +0200, Jani Nikula wrote:
> -unsigned int
> -intel_plane_fence_y_offset(const struct intel_plane_state *plane_state)
> -{
> - int x = 0, y = 0;
> -
> - intel_plane_adjust_aligned_offset(&x, &y, plane_state, 0,
> - plane_state->color_plane[0].offset, 0);
> -
> - return y;
> -}
This unrelated code motion is still here, messing up the diff.
<snip>
> }
>
> -void skl_scaler_disable(const struct intel_crtc_state *old_crtc_state)
> -{
> - struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
> - int i;
> -
> - for (i = 0; i < crtc->num_scalers; i++)
> - skl_detach_scaler(crtc, i);
> -}
ditto
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-04 20:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 19:43 [Intel-gfx] [PATCH v11 00/10] drm/i915: refactor intel_display.c + a bit more Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 01/10] drm/i915: refactor ddi translations into a separate file (v2) Jani Nikula
2021-02-05 13:48 ` Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 02/10] drm/i915: migrate hsw fdi code to new file Jani Nikula
2021-02-05 13:52 ` Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 03/10] drm/i915: migrate skl planes code new file (v5) Jani Nikula
2021-02-04 20:28 ` Ville Syrjälä [this message]
2021-02-04 20:35 ` Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 04/10] drm/i915: move pipe update code into crtc. (v2) Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 05/10] drm/i915: split fb scalable checks into g4x and skl versions Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 06/10] drm/i915: move is_ccs_modifier to an inline Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 07/10] drm/i915: migrate pll enable/disable code to intel_dpll.[ch] Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 08/10] drm/i915: migrate i9xx plane get config Jani Nikula
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 09/10] drm/i915: refactor skylake scaler code into new file Jani Nikula
2021-02-04 20:35 ` Ville Syrjälä
2021-02-04 19:43 ` [Intel-gfx] [PATCH v11 10/10] drm/i915: move ddi pll state get to dpll mgr Jani Nikula
2021-02-04 22:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: refactor intel_display.c + a bit more Patchwork
2021-02-04 22:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-02-04 23:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-05 6:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBxY6VV00sNJ/rqR@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.