From: Greg KH <gregkh@linuxfoundation.org>
To: Prakash Dubey <prakashdubey1999@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: fwserial: fix alignment of function parameters
Date: Fri, 19 Feb 2021 14:16:51 +0100 [thread overview]
Message-ID: <YC+6QxVMfl2cq7QC@kroah.com> (raw)
In-Reply-To: <20210219105112.GA8315@gmail.com>
On Fri, Feb 19, 2021 at 04:21:12PM +0530, Prakash Dubey wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Prakash Dubey <prakashdubey1999@gmail.com>
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> index a92741b8b6c6..137e97c9406c 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
> if (state == -1) {
> set_bit(STOP_TX, &port->flags);
> ret = wait_event_interruptible_timeout(port->wait_tx,
> - !test_bit(IN_TX, &port->flags),
> - 10);
> + !test_bit(IN_TX, &port->flags),
> + 10);
> if (ret == 0 || ret == -ERESTARTSYS) {
> clear_bit(STOP_TX, &port->flags);
> fwtty_restart_tx(port);
> --
> 2.25.1
Does not apply to my tree at all, please be sure to always work off of
linux-next or my staging-next tree so as not to duplicate work that
others have already done.
thanks,
greg k-h
prev parent reply other threads:[~2021-02-19 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 10:51 [PATCH v2] staging: fwserial: fix alignment of function parameters Prakash Dubey
2021-02-19 13:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC+6QxVMfl2cq7QC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakashdubey1999@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.