From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:690d:0:0:0:0:0 with SMTP id e13csp8972375lfc; Fri, 19 Feb 2021 04:19:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBPtiu80q01VZwCKOVNxI/TwoxXSi/iQmxphLU9TUbStBBSsb+Yi5P3hH/Q+33wdga0RVn X-Received: by 2002:a25:560a:: with SMTP id k10mr13890228ybb.165.1613737164700; Fri, 19 Feb 2021 04:19:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613737164; cv=none; d=google.com; s=arc-20160816; b=aQwohOVij18GoRTdEA+IRf1rxDwPRkCXprUdN/5paDzPvzcXaTYnztwkm0vvWGmzff 2tE2+9BG/UmLcCvgYJLY3dAtMWQ64rmUZWRvwitnsfFI1uOXE+8IGrc7uiMZTUDeAKgC lYDSflI25KTcVbf8UIMWsJm826nsQgQNSgHH65tHyWUD9ihGoeQsEeWLfoIOuHBb5y6Y AHjb/c/FvEaLZxH4uU7NUFk24f/a5yj7sLl1zoyzFwO8PKknXRSikVaHJZn1RlA6AsW5 panm6jS41srJ62eIhWGQ6VCyBG7IVjJIK4iO9LXaKdFXSv2GdGRX8mVfBZzpDEAAl9nH 86mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=u7HT95kkWTHrCt+Iv/CYRhOhkzd75rYC+HIZYMaBL0w=; b=XCaVkDqVClIkBut8nsmkqL5CqISPKDCfm1fOLBX6lIv/Q6FXGc2PMvwwK5wjUiyKW2 XmkAh/sGZ+b05zA1WbFQVWL/qeoKJgx5IkDNWENCyWjmZBt8HylurQGgiKnT7yS4ynhJ 1WVzod6bMoJUc32jJEZKDKRldExuRaZtsjoWKmx9h/ChCdMwa/dsVqAnEcXIEwMMiPMz pub7yfvc2LTHxfJm3t3/1bjF7lhJCuXaKYCkdIgIVZ6YOWhII6GLtfS/x+0wa+4wEtLu LRH0Bcep/RirXG4kJ/sFJTmg3UeErnvqZLyiU9jFx21O45tW3j0DAglc0ykGTLzqWBCP uQnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="DYJjov/t"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x133si9658701ybx.26.2021.02.19.04.19.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Feb 2021 04:19:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="DYJjov/t"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:37084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD4km-0006yU-3X for alex.bennee@linaro.org; Fri, 19 Feb 2021 07:19:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD4ju-0005xH-FL for qemu-arm@nongnu.org; Fri, 19 Feb 2021 07:18:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lD4js-0007XX-EA for qemu-arm@nongnu.org; Fri, 19 Feb 2021 07:18:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613737107; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u7HT95kkWTHrCt+Iv/CYRhOhkzd75rYC+HIZYMaBL0w=; b=DYJjov/tPfEBp2cNlrCN54S+zi+m6FG7Z7Er9wO0Fv9xcqHTNDFSgJFC87fXKakp+QTBFq eWON8SzyoCnZi1O6Sk9K3IJ/axPeKWH29StH9PFSp/hjXFLraNd4mNylbd/wfFW1JCDoJt XFlq3fa4RE8PoJ4LGN4HAqlulWmQZ6w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-F-2IZ9plOnqioXOAJ81nqg-1; Fri, 19 Feb 2021 07:18:26 -0500 X-MC-Unique: F-2IZ9plOnqioXOAJ81nqg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5EA278030B7; Fri, 19 Feb 2021 12:18:23 +0000 (UTC) Received: from redhat.com (ovpn-113-184.ams2.redhat.com [10.36.113.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2547560BE5; Fri, 19 Feb 2021 12:18:11 +0000 (UTC) Date: Fri, 19 Feb 2021 12:18:09 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported Message-ID: References: <20210219114428.1936109-1-philmd@redhat.com> <9540912b-1a81-1fd2-4710-2b81d5e69c5f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9540912b-1a81-1fd2-4710-2b81d5e69c5f@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , Mark Cave-Ayland , qemu-devel@nongnu.org, Huacai Chen , Halil Pasic , Christian Borntraeger , =?utf-8?B?SGVydsOp?= Poussineau , Leif Lindholm , Thomas Huth , Eduardo Habkost , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Radoslaw Biernacki , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: aeDxBrwzx8RJ On Fri, Feb 19, 2021 at 01:15:25PM +0100, Philippe Mathieu-Daudé wrote: > On 2/19/21 1:00 PM, Daniel P. Berrangé wrote: > > On Fri, Feb 19, 2021 at 12:44:21PM +0100, Philippe Mathieu-Daudé wrote: > >> Hi, > >> > >> This series aims to improve user experience by providing > >> a better error message when the user tries to enable KVM > >> on machines not supporting it. > > > > Improved error message is good, but it is better if the mgmt apps knows > > not to try this in the first place. > > I am not sure this is the same problem. This series addresses > users from the command line (without mgmt app). Users of mgmt apps can launch the same problematic raspbi + KVM config as people who don't use a mgmt app. > > IOW, I think we want "query-machines" to filter out machines > > which are not available with the currently configured accelerator. > > > > libvirt will probe separately with both TCG and KVM enabled, so if > > query-machines can give the right answer in these cases, libvirt > > will probably "just work" and not offer to even start such a VM. > > Yes, agreed. There are other discussions about 'query-machines' > and an eventual 'query-accels'. This series doesn't aim to fix > the mgmt app problems. I think this should be fixing query-machines right now. It shouldn't be much harder than a single if (...) test in the code. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4ECC433DB for ; Fri, 19 Feb 2021 12:19:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A4E464EB8 for ; Fri, 19 Feb 2021 12:19:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbhBSMT6 (ORCPT ); Fri, 19 Feb 2021 07:19:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:53212 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhBSMT4 (ORCPT ); Fri, 19 Feb 2021 07:19:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613737109; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u7HT95kkWTHrCt+Iv/CYRhOhkzd75rYC+HIZYMaBL0w=; b=XRli+cy8a84OZv7lFiTrl1Nss2cL2f9hzBRUK/PbagRXIdURu5vc+IQCxiO7+9YIDvTthB cJxM4ilIvfhKXGJp+5vQdPvSIU2RssAGVdFyWCCDXf3Qwf01RaPHkPEDRH5b2Swf1sX94g NFCxU0qCzQiZH7o+df3/KE+kMMGfta8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-F-2IZ9plOnqioXOAJ81nqg-1; Fri, 19 Feb 2021 07:18:26 -0500 X-MC-Unique: F-2IZ9plOnqioXOAJ81nqg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5EA278030B7; Fri, 19 Feb 2021 12:18:23 +0000 (UTC) Received: from redhat.com (ovpn-113-184.ams2.redhat.com [10.36.113.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2547560BE5; Fri, 19 Feb 2021 12:18:11 +0000 (UTC) Date: Fri, 19 Feb 2021 12:18:09 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Radoslaw Biernacki , kvm@vger.kernel.org, David Hildenbrand , Mark Cave-Ayland , Thomas Huth , "Edgar E. Iglesias" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?utf-8?B?SGVydsOp?= Poussineau , Leif Lindholm , Aleksandar Rikalo , Eduardo Habkost , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Subject: Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20210219114428.1936109-1-philmd@redhat.com> <9540912b-1a81-1fd2-4710-2b81d5e69c5f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9540912b-1a81-1fd2-4710-2b81d5e69c5f@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Feb 19, 2021 at 01:15:25PM +0100, Philippe Mathieu-Daudé wrote: > On 2/19/21 1:00 PM, Daniel P. Berrangé wrote: > > On Fri, Feb 19, 2021 at 12:44:21PM +0100, Philippe Mathieu-Daudé wrote: > >> Hi, > >> > >> This series aims to improve user experience by providing > >> a better error message when the user tries to enable KVM > >> on machines not supporting it. > > > > Improved error message is good, but it is better if the mgmt apps knows > > not to try this in the first place. > > I am not sure this is the same problem. This series addresses > users from the command line (without mgmt app). Users of mgmt apps can launch the same problematic raspbi + KVM config as people who don't use a mgmt app. > > IOW, I think we want "query-machines" to filter out machines > > which are not available with the currently configured accelerator. > > > > libvirt will probe separately with both TCG and KVM enabled, so if > > query-machines can give the right answer in these cases, libvirt > > will probably "just work" and not offer to even start such a VM. > > Yes, agreed. There are other discussions about 'query-machines' > and an eventual 'query-accels'. This series doesn't aim to fix > the mgmt app problems. I think this should be fixing query-machines right now. It shouldn't be much harder than a single if (...) test in the code. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0943C433E0 for ; Fri, 19 Feb 2021 12:20:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3660360C41 for ; Fri, 19 Feb 2021 12:20:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3660360C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD4mD-0000Es-4I for qemu-devel@archiver.kernel.org; Fri, 19 Feb 2021 07:20:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD4jw-00060O-0C for qemu-devel@nongnu.org; Fri, 19 Feb 2021 07:18:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lD4js-0007XZ-Ph for qemu-devel@nongnu.org; Fri, 19 Feb 2021 07:18:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613737107; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u7HT95kkWTHrCt+Iv/CYRhOhkzd75rYC+HIZYMaBL0w=; b=DYJjov/tPfEBp2cNlrCN54S+zi+m6FG7Z7Er9wO0Fv9xcqHTNDFSgJFC87fXKakp+QTBFq eWON8SzyoCnZi1O6Sk9K3IJ/axPeKWH29StH9PFSp/hjXFLraNd4mNylbd/wfFW1JCDoJt XFlq3fa4RE8PoJ4LGN4HAqlulWmQZ6w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-F-2IZ9plOnqioXOAJ81nqg-1; Fri, 19 Feb 2021 07:18:26 -0500 X-MC-Unique: F-2IZ9plOnqioXOAJ81nqg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5EA278030B7; Fri, 19 Feb 2021 12:18:23 +0000 (UTC) Received: from redhat.com (ovpn-113-184.ams2.redhat.com [10.36.113.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2547560BE5; Fri, 19 Feb 2021 12:18:11 +0000 (UTC) Date: Fri, 19 Feb 2021 12:18:09 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 0/7] hw/kvm: Exit gracefully when KVM is not supported Message-ID: References: <20210219114428.1936109-1-philmd@redhat.com> <9540912b-1a81-1fd2-4710-2b81d5e69c5f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9540912b-1a81-1fd2-4710-2b81d5e69c5f@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , Mark Cave-Ayland , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?utf-8?B?SGVydsOp?= Poussineau , Leif Lindholm , Thomas Huth , Eduardo Habkost , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Radoslaw Biernacki , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Feb 19, 2021 at 01:15:25PM +0100, Philippe Mathieu-Daudé wrote: > On 2/19/21 1:00 PM, Daniel P. Berrangé wrote: > > On Fri, Feb 19, 2021 at 12:44:21PM +0100, Philippe Mathieu-Daudé wrote: > >> Hi, > >> > >> This series aims to improve user experience by providing > >> a better error message when the user tries to enable KVM > >> on machines not supporting it. > > > > Improved error message is good, but it is better if the mgmt apps knows > > not to try this in the first place. > > I am not sure this is the same problem. This series addresses > users from the command line (without mgmt app). Users of mgmt apps can launch the same problematic raspbi + KVM config as people who don't use a mgmt app. > > IOW, I think we want "query-machines" to filter out machines > > which are not available with the currently configured accelerator. > > > > libvirt will probe separately with both TCG and KVM enabled, so if > > query-machines can give the right answer in these cases, libvirt > > will probably "just work" and not offer to even start such a VM. > > Yes, agreed. There are other discussions about 'query-machines' > and an eventual 'query-accels'. This series doesn't aim to fix > the mgmt app problems. I think this should be fixing query-machines right now. It shouldn't be much harder than a single if (...) test in the code. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|