From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
corbet@lwn.net, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
helgaas@kernel.org, wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function
Date: Wed, 17 Feb 2021 15:47:01 +0200 [thread overview]
Message-ID: <YC0eVZf4Xci0IF5+@smile.fi.intel.com> (raw)
In-Reply-To: <20210217114014.GB766103@nuc8i5>
On Wed, Feb 17, 2021 at 07:40:14PM +0800, Dejin Zheng wrote:
> On Tue, Feb 16, 2021 at 06:46:01PM +0100, Krzysztof Wilczyński wrote:
...
> > The change simplifies the error handling path, how? A line of two which
> > explains how it has been achieved might help should someone reads the
> > commit message in the future.
> >
> To put it simply, if the driver probe fail, the device-managed function
> mechanism will automatically call pcim_release(), then the pci_free_irq_vectors()
> will be executed. For details, please see the relevant code.
Perhaps as a compromise you may add this short sentence to your commit
messages, like "the freeing resources will take automatically when device
is gone".
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-17 13:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 16:02 [PATCH v3 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 16:02 ` [PATCH v3 1/4] PCI: " Dejin Zheng
2021-02-16 17:53 ` Krzysztof Wilczyński
2021-02-16 16:02 ` [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 17:10 ` Krzysztof Wilczyński
2021-02-17 10:50 ` Dejin Zheng
2021-02-17 13:44 ` Andy Shevchenko
2021-02-16 16:02 ` [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-16 17:46 ` Krzysztof Wilczyński
2021-02-17 11:40 ` Dejin Zheng
2021-02-17 13:47 ` Andy Shevchenko [this message]
2021-02-18 14:15 ` Dejin Zheng
2021-02-16 16:02 ` [PATCH v3 4/4] i2c: thunderx: " Dejin Zheng
2021-02-16 17:49 ` Krzysztof Wilczyński
2021-02-18 9:36 ` [PATCH v3 0/4] Introduce pcim_alloc_irq_vectors() Robert Richter
2021-02-18 14:01 ` Andy Shevchenko
2021-02-19 11:19 ` Robert Richter
2021-02-19 13:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC0eVZf4Xci0IF5+@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.