All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sean Behan <codebam@riseup.net>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	nathan@kernel.org, Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	Colin Ian King <colin.king@canonical.com>,
	Alex Dewar <alex.dewar90@gmail.com>
Subject: Re: [PATCH] staging: emxx_udc: remove unused variable driver_desc
Date: Wed, 17 Feb 2021 15:37:04 +0100	[thread overview]
Message-ID: <YC0qECFf+05Flik0@kroah.com> (raw)
In-Reply-To: <20210217142420.7350-1-codebam@riseup.net>

On Wed, Feb 17, 2021 at 09:24:17AM -0500, Sean Behan wrote:
> When building with W=1, there is a warning that this variable is unused.
> 
> It is not used so remove it to fix the warning.
> 
> Thanks to nathan@kernel.org for helping me submit my first patch.

This is nice, but is it needed in the changelog text?  Please put it
below the --- line when you resend.

thanks,

greg k-h

  reply	other threads:[~2021-02-17 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 14:24 [PATCH] staging: emxx_udc: remove unused variable driver_desc Sean Behan
2021-02-17 14:37 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-19  3:41 Sean Behan
2021-02-19  6:03 ` Greg Kroah-Hartman
2021-02-17 14:21 Sean Behan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC0qECFf+05Flik0@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alex.dewar90@gmail.com \
    --cc=codebam@riseup.net \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.