All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf annotate: do not jump after 'k' is pressed
Date: Wed, 17 Feb 2021 15:25:40 -0300	[thread overview]
Message-ID: <YC1fpJIJFFfrNLUI@kernel.org> (raw)
In-Reply-To: <65416cff-4eb6-713c-a174-2aa43fa64332@suse.cz>

Em Mon, Feb 15, 2021 at 01:45:25PM +0100, Martin Liška escreveu:
> Do not jump when 'k' is pressed, the cursor show stay where it is.
> Right now, it jumps to the currently selected hot instruction.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Martin Liška <mliska@suse.cz>
> ---
>  tools/perf/ui/browsers/annotate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> index bd77825fd5a1..35b82caf8090 100644
> --- a/tools/perf/ui/browsers/annotate.c
> +++ b/tools/perf/ui/browsers/annotate.c
> @@ -759,7 +759,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
>  			continue;
>  		case 'k':
>  			notes->options->show_linenr = !notes->options->show_linenr;
> -			break;
> +			continue;
>  		case 'H':
>  			nd = browser->curr_hot;
>  			break;
> -- 
> 2.30.0
> 

-- 

- Arnaldo

      reply	other threads:[~2021-02-17 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 12:45 [PATCH] perf annotate: do not jump after 'k' is pressed Martin Liška
2021-02-17 18:25 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC1fpJIJFFfrNLUI@kernel.org \
    --to=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.