From: Jarkko Sakkinen <jarkko@kernel.org>
To: David Laight <David.Laight@aculab.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"stefanb@linux.vnet.ibm.com" <stefanb@linux.vnet.ibm.com>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lino Sanfilippo <l.sanfilippo@kunbus.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip
Date: Thu, 18 Feb 2021 00:14:11 +0200 [thread overview]
Message-ID: <YC2VM1JI0tECPs7g@kernel.org> (raw)
In-Reply-To: <74bbc76260594a8a8f7993ab66cca104@AcuMS.aculab.com>
On Tue, Feb 16, 2021 at 04:31:26PM +0000, David Laight wrote:
> ...
> > > > + get_device(&chip->dev);
> > > > + chip->devs.release = tpm_devs_release;
> > > > + chip->devs.devt =
> > > > + MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES);
> >
> > Isn't this less than 100 chars?
>
> Still best kept under 80 if 'reasonable'?
>
> Really it is just split in the wrong place:
> chip->devs.devt = MKDEV(MAJOR(tpm_devt),
> chip->dev_num + TPM_NUM_DEVICES);
Well it looks crap IMHO. Would be more reasonable to have it in a single
like. And it is legit too, since it is accepted by checkpatch.
You might break the lines within 80 chars if it is somehow "logically"
consistent.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
>
/Jarkko
next prev parent reply other threads:[~2021-02-17 22:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 0:30 [PATCH v4] TPM fixes Lino Sanfilippo
2021-02-16 0:31 ` [PATCH v4] tpm: fix reference counting for struct tpm_chip Lino Sanfilippo
2021-02-16 8:27 ` Jarkko Sakkinen
2021-02-16 12:53 ` Jason Gunthorpe
2021-02-16 16:04 ` Jarkko Sakkinen
2021-02-16 16:09 ` Jarkko Sakkinen
2021-02-16 16:11 ` Jarkko Sakkinen
2021-02-16 19:08 ` Lino Sanfilippo
2021-02-16 16:31 ` David Laight
2021-02-17 22:14 ` Jarkko Sakkinen [this message]
2021-02-18 1:27 ` Jason Gunthorpe
2021-02-19 7:07 ` Jarkko Sakkinen
2021-02-16 19:15 ` Lino Sanfilippo
2021-02-16 19:04 ` Lino Sanfilippo
2021-02-16 16:52 ` Stefan Berger
2021-02-16 19:17 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC2VM1JI0tECPs7g@kernel.org \
--to=jarkko@kernel.org \
--cc=David.Laight@aculab.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=LinoSanfilippo@gmx.de \
--cc=jgg@ziepe.ca \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.