From: Denton Liu <liu.denton@gmail.com>
To: Joey Salazar <jgsal@protonmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt
Date: Wed, 17 Feb 2021 19:49:15 -0800 [thread overview]
Message-ID: <YC3ju7Jg9TyvRF2d@generichostname> (raw)
In-Reply-To: <k1OL_yTjmhqRPUI_3wZNi4FpD0yadrwMKu1CaOXO07YyMBQG5hYoUKFtndt6mlNBKMxyCgm3JGf2YcENx-vRasj1W8keEI6ITVvkaqOi2_Q=@protonmail.com>
On Thu, Feb 18, 2021 at 12:11:22AM +0000, Joey Salazar wrote:
> Git Protocol version 2[1] defines 0002 as a Message Packet that indicates
> the end of a response for stateless connections.
>
> Change the naming of the 0002 Packet to 'Response End' to match the
> parsing introduced in Wireshark's MR !1922 for consistency. A subsequent
> MR in Wireshark will address additional mismatches.
>
> [1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html
> [2] gitlab.com/wireshark/wireshark/-/merge_requests/1922
>
> Signed-off-by: Joey Salazar <jgsal@protonmail.com>
Reviewed-by: Denton Liu <liu.denton@gmail.com>
> ---
> Documentation/technical/protocol-v2.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt
> index e597b74da39..fc163ca605c 100644
> --- a/Documentation/technical/protocol-v2.txt
> +++ b/Documentation/technical/protocol-v2.txt
> @@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics:
>
> * '0000' Flush Packet (flush-pkt) - indicates the end of a message
> * '0001' Delimiter Packet (delim-pkt) - separates sections of a message
> - * '0002' Message Packet (response-end-pkt) - indicates the end of a response
> - for stateless connections
> + * '0002' Response End Packet (response-end-pkt) - indicates the end of a
> + response for stateless connections
>
> Initial Client Request
> ----------------------
> --
> 2.29.0.rc2
>
prev parent reply other threads:[~2021-02-18 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 0:11 [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt Joey Salazar
2021-02-18 3:49 ` Denton Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC3ju7Jg9TyvRF2d@generichostname \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=jgsal@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.